Title: [277315] trunk
- Revision
- 277315
- Author
- [email protected]
- Date
- 2021-05-10 19:14:57 -0700 (Mon, 10 May 2021)
Log Message
[ macOS Release wk2 ] http/tests/cache-storage/cache-records-persistency.https.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=225522
<rdar://problem/77680019>
Reviewed by Darin Adler.
Source/WTF:
Pass ec parameter to std::filesystem::directory_iterator() so that it doesn't throw in case of the
path does not exist. Normally, the function would return early earlier if the path does not exist
or isn't a directory. However, in the context of the test, this function is getting called on a
background thread and another thread is deleting the directory in parallel.
* wtf/FileSystem.cpp:
(WTF::FileSystemImpl::deleteEmptyDirectory):
LayoutTests:
Restore previous expectation for the test, now that it is no longer flaky crashing.
* platform/mac-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (277314 => 277315)
--- trunk/LayoutTests/ChangeLog 2021-05-11 02:05:52 UTC (rev 277314)
+++ trunk/LayoutTests/ChangeLog 2021-05-11 02:14:57 UTC (rev 277315)
@@ -1,3 +1,15 @@
+2021-05-10 Chris Dumez <[email protected]>
+
+ [ macOS Release wk2 ] http/tests/cache-storage/cache-records-persistency.https.html is flaky crashing
+ https://bugs.webkit.org/show_bug.cgi?id=225522
+ <rdar://problem/77680019>
+
+ Reviewed by Darin Adler.
+
+ Restore previous expectation for the test, now that it is no longer flaky crashing.
+
+ * platform/mac-wk2/TestExpectations:
+
2021-05-10 Chris Gambrell <[email protected]>
[LayoutTests] Decouple http/tests/media/resources/create-id3-db.php from webserver
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (277314 => 277315)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-05-11 02:05:52 UTC (rev 277314)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-05-11 02:14:57 UTC (rev 277315)
@@ -1390,10 +1390,10 @@
webkit.org/b/224784 [ BigSur Release arm64 ] imported/w3c/web-platform-tests/navigation-timing/test_performance_attributes.sub.html [ Pass Failure ]
-webkit.org/b/225522 [ Release ] http/tests/cache-storage/cache-records-persistency.https.html [ Pass Failure Crash ]
+webkit.org/b/207474 http/tests/cache-storage/cache-records-persistency.https.html [ Pass Failure ]
webkit.org/b/225529 [ BigSur Release arm64 ] scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-in-iframe.html [ Pass Failure ]
webkit.org/b/225534 [ BigSur Debug arm64 ] imported/w3c/web-platform-tests/webrtc-encoded-transform/sframe-transform-readable.html [ Pass Crash ]
-webkit.org/b/225533 [ BigSur Release arm64 ] mathml/scripts-removeChild.html [ Pass ImageOnlyFailure ]
\ No newline at end of file
+webkit.org/b/225533 [ BigSur Release arm64 ] mathml/scripts-removeChild.html [ Pass ImageOnlyFailure ]
Modified: trunk/Source/WTF/ChangeLog (277314 => 277315)
--- trunk/Source/WTF/ChangeLog 2021-05-11 02:05:52 UTC (rev 277314)
+++ trunk/Source/WTF/ChangeLog 2021-05-11 02:14:57 UTC (rev 277315)
@@ -1,3 +1,19 @@
+2021-05-10 Chris Dumez <[email protected]>
+
+ [ macOS Release wk2 ] http/tests/cache-storage/cache-records-persistency.https.html is flaky crashing
+ https://bugs.webkit.org/show_bug.cgi?id=225522
+ <rdar://problem/77680019>
+
+ Reviewed by Darin Adler.
+
+ Pass ec parameter to std::filesystem::directory_iterator() so that it doesn't throw in case of the
+ path does not exist. Normally, the function would return early earlier if the path does not exist
+ or isn't a directory. However, in the context of the test, this function is getting called on a
+ background thread and another thread is deleting the directory in parallel.
+
+ * wtf/FileSystem.cpp:
+ (WTF::FileSystemImpl::deleteEmptyDirectory):
+
2021-05-10 Devin Rousso <[email protected]>
`SLEEP_THREAD_FOR_DEBUGGER` should print the PID before sleeping
Modified: trunk/Source/WTF/wtf/FileSystem.cpp (277314 => 277315)
--- trunk/Source/WTF/wtf/FileSystem.cpp 2021-05-11 02:05:52 UTC (rev 277314)
+++ trunk/Source/WTF/wtf/FileSystem.cpp 2021-05-11 02:14:57 UTC (rev 277315)
@@ -562,7 +562,7 @@
#if PLATFORM(MAC)
bool containsSingleDSStoreFile = false;
- for (auto& entry : std::filesystem::directory_iterator(fsPath)) {
+ for (auto& entry : std::filesystem::directory_iterator(fsPath, ec)) {
if (entry.path().filename() == ".DS_Store")
containsSingleDSStoreFile = true;
else {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
