Title: [277326] trunk/Source/_javascript_Core
Revision
277326
Author
fpi...@apple.com
Date
2021-05-11 08:52:17 -0700 (Tue, 11 May 2021)

Log Message

Tune number of threads for AS
https://bugs.webkit.org/show_bug.cgi?id=225635

Reviewed by Mark Lam.

Using 4 GC markers (which really means 3 parallel GC worker threads -- the mutator thread is
the 4th), 2 DFG threads, and 2 FTL threads seems to be more optimal than going off ncpu.

~1% JetStream2 speed-up, ~1% Speedometer2 speed-up.

* runtime/Options.cpp:
(JSC::overrideDefaults):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (277325 => 277326)


--- trunk/Source/_javascript_Core/ChangeLog	2021-05-11 15:33:13 UTC (rev 277325)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-05-11 15:52:17 UTC (rev 277326)
@@ -1,3 +1,18 @@
+2021-05-10  Filip Pizlo  <fpi...@apple.com>
+
+        Tune number of threads for AS
+        https://bugs.webkit.org/show_bug.cgi?id=225635
+
+        Reviewed by Mark Lam.
+
+        Using 4 GC markers (which really means 3 parallel GC worker threads -- the mutator thread is
+        the 4th), 2 DFG threads, and 2 FTL threads seems to be more optimal than going off ncpu.
+
+        ~1% JetStream2 speed-up, ~1% Speedometer2 speed-up.
+
+        * runtime/Options.cpp:
+        (JSC::overrideDefaults):
+
 2021-05-10  Mark Lam  <mark....@apple.com>
 
         Removed unused CallRecord::bytecodeIndex field.

Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (277325 => 277326)


--- trunk/Source/_javascript_Core/runtime/Options.cpp	2021-05-11 15:33:13 UTC (rev 277325)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp	2021-05-11 15:52:17 UTC (rev 277326)
@@ -352,6 +352,12 @@
             Options::gcIncrementScale() = 0;
     }
 
+#if PLATFORM(MAC) && CPU(ARM64)
+    Options::numberOfGCMarkers() = 4;
+    Options::numberOfDFGCompilerThreads() = 2;
+    Options::numberOfFTLCompilerThreads() = 2;
+#endif
+
 #if USE(BMALLOC_MEMORY_FOOTPRINT_API)
     // On iOS and conditionally Linux, we control heap growth using process memory footprint. Therefore these values can be agressive.
     Options::smallHeapRAMFraction() = 0.8;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to