Title: [277328] trunk/Source/WebCore
- Revision
- 277328
- Author
- [email protected]
- Date
- 2021-05-11 10:16:06 -0700 (Tue, 11 May 2021)
Log Message
Unreviewed, reverting r277322.
https://bugs.webkit.org/show_bug.cgi?id=225657
Causing build failure
Reverted changeset:
"Adopt CoreMedia SPI to identify audio-only playback for MSE
clients"
https://bugs.webkit.org/show_bug.cgi?id=225647
https://trac.webkit.org/changeset/277322
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (277327 => 277328)
--- trunk/Source/WebCore/ChangeLog 2021-05-11 17:14:16 UTC (rev 277327)
+++ trunk/Source/WebCore/ChangeLog 2021-05-11 17:16:06 UTC (rev 277328)
@@ -1,3 +1,17 @@
+2021-05-11 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r277322.
+ https://bugs.webkit.org/show_bug.cgi?id=225657
+
+ Causing build failure
+
+ Reverted changeset:
+
+ "Adopt CoreMedia SPI to identify audio-only playback for MSE
+ clients"
+ https://bugs.webkit.org/show_bug.cgi?id=225647
+ https://trac.webkit.org/changeset/277322
+
2021-05-11 Zalan Bujtas <[email protected]>
REGRESSION(r275515): wpt/quirks/blocks-ignore-line-height.html
Modified: trunk/Source/WebCore/PAL/ChangeLog (277327 => 277328)
--- trunk/Source/WebCore/PAL/ChangeLog 2021-05-11 17:14:16 UTC (rev 277327)
+++ trunk/Source/WebCore/PAL/ChangeLog 2021-05-11 17:16:06 UTC (rev 277328)
@@ -1,3 +1,17 @@
+2021-05-11 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r277322.
+ https://bugs.webkit.org/show_bug.cgi?id=225657
+
+ Causing build failure
+
+ Reverted changeset:
+
+ "Adopt CoreMedia SPI to identify audio-only playback for MSE
+ clients"
+ https://bugs.webkit.org/show_bug.cgi?id=225647
+ https://trac.webkit.org/changeset/277322
+
2021-05-11 Jean-Yves Avenard <[email protected]>
Adopt CoreMedia SPI to identify audio-only playback for MSE clients
Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h (277327 => 277328)
--- trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h 2021-05-11 17:14:16 UTC (rev 277327)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h 2021-05-11 17:16:06 UTC (rev 277328)
@@ -338,11 +338,6 @@
#if __has_include(<AVFoundation/AVSampleBufferAudioRenderer.h>)
#import <AVFoundation/AVSampleBufferAudioRenderer.h>
-NS_ASSUME_NONNULL_BEGIN
-@interface AVSampleBufferAudioRenderer (AVSampleBufferAudioRendererWebKitOnly)
-- (void)setIsUnaccompaniedByVisuals:(BOOL)audioOnly SPI_AVAILABLE(macos(12.0)) API_UNAVAILABLE(ios, tvos, watchos);
-@end
-NS_ASSUME_NONNULL_END
#else
NS_ASSUME_NONNULL_BEGIN
@@ -357,7 +352,6 @@
- (void)stopRequestingMediaData;
- (void)setVolume:(float)volume;
- (void)setMuted:(BOOL)muted;
-- (void)setIsUnaccompaniedByVisuals:(BOOL)audioOnly;
@property (nonatomic, copy) NSString *audioTimePitchAlgorithm;
@end
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (277327 => 277328)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2021-05-11 17:14:16 UTC (rev 277327)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2021-05-11 17:16:06 UTC (rev 277328)
@@ -1169,10 +1169,6 @@
[audioRenderer setMuted:m_player->muted()];
[audioRenderer setVolume:m_player->volume()];
[audioRenderer setAudioTimePitchAlgorithm:(m_player->preservesPitch() ? AVAudioTimePitchAlgorithmSpectral : AVAudioTimePitchAlgorithmVarispeed)];
- ALLOW_NEW_API_WITHOUT_GUARDS_BEGIN
- if ([audioRenderer respondsToSelector:@selector(setIsUnaccompaniedByVisuals:)])
- [audioRenderer setIsUnaccompaniedByVisuals:!m_player->isVideoPlayer()];
- ALLOW_NEW_API_WITHOUT_GUARDS_END
#if HAVE(AUDIO_OUTPUT_DEVICE_UNIQUE_ID)
auto deviceId = m_player->audioOutputDeviceIdOverride();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes