Title: [277359] trunk/LayoutTests
- Revision
- 277359
- Author
- [email protected]
- Date
- 2021-05-12 00:54:27 -0700 (Wed, 12 May 2021)
Log Message
fast/mediastream/getUserMedia-webaudio.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=225655
<rdar://74158395>
Reviewed by Eric Carlson.
* fast/mediastream/getUserMedia-webaudio.html:
Retry several time instead of just once when detecting no noise to improve robustness.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (277358 => 277359)
--- trunk/LayoutTests/ChangeLog 2021-05-12 06:04:18 UTC (rev 277358)
+++ trunk/LayoutTests/ChangeLog 2021-05-12 07:54:27 UTC (rev 277359)
@@ -1,3 +1,14 @@
+2021-05-12 Youenn Fablet <[email protected]>
+
+ fast/mediastream/getUserMedia-webaudio.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=225655
+ <rdar://74158395>
+
+ Reviewed by Eric Carlson.
+
+ * fast/mediastream/getUserMedia-webaudio.html:
+ Retry several time instead of just once when detecting no noise to improve robustness.
+
2021-05-11 Cameron McCormack <[email protected]>
Include reasons for compositing in showLayerTree output
Modified: trunk/LayoutTests/fast/mediastream/getUserMedia-webaudio.html (277358 => 277359)
--- trunk/LayoutTests/fast/mediastream/getUserMedia-webaudio.html 2021-05-12 06:04:18 UTC (rev 277358)
+++ trunk/LayoutTests/fast/mediastream/getUserMedia-webaudio.html 2021-05-12 07:54:27 UTC (rev 277359)
@@ -87,7 +87,7 @@
}, "Web Audio should work with mock audio destination");
var context;
-async function checkForNoise(stream, counter)
+async function checkForNoise(stream, expectedHeardNoise, counter)
{
if (!counter)
counter = 1;
@@ -94,26 +94,22 @@
else if (++counter > 50)
return Promise.resolve(false);
results = await analyseAudio(stream, 100, context);
- if (results.heardNoise)
+ if (results.heardNoise == expectedHeardNoise)
return Promise.resolve(true);
- var results = await checkForNoise(stream, counter);
+ var results = await checkForNoise(stream, expectedHeardNoise, counter);
return results;
}
promise_test(async (test) => {
context = new AudioContext();
- if (window.testRunner)
- testRunner.setUserMediaPermission(true);
let stream = await navigator.mediaDevices.getUserMedia({audio: { echoCancellation : true}});
assert_true(stream.getAudioTracks()[0].getSettings().echoCancellation);
- const results = await analyseAudio(stream, 100, context);
- assert_false(results.heardNoise, "should not hear noise");
+ assert_true(await checkForNoise(stream, false), "should not hear noise");
stream = await navigator.mediaDevices.getUserMedia({audio: { echoCancellation : false}});
assert_false(stream.getAudioTracks()[0].getSettings().echoCancellation, "settings is ok");
- const heardNoise = await checkForNoise(stream);
- assert_true(heardNoise, "heard noise");
+ assert_true(await checkForNoise(stream, true), "heard noise");
context.close();
context = null;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
