Title: [277362] trunk/Source/WebKit
- Revision
- 277362
- Author
- [email protected]
- Date
- 2021-05-12 01:09:06 -0700 (Wed, 12 May 2021)
Log Message
REGRESSION(r277083): Proximity scroll snap is broken on iOS
https://bugs.webkit.org/show_bug.cgi?id=225649
Patch by Martin Robinson <[email protected]> on 2021-05-12
Reviewed by Simon Fraser.
No new tests. iOS does not have great support for the event sending test
infrastructure used to test scroll snap.
* Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder<FloatScrollSnapOffsetsInfo>::encode): Include the snap type when encoding ScrollSnapOffsetsInfo.
(ArgumentCoder<FloatScrollSnapOffsetsInfo>::decode): Include the snap type when decoding ScrollSnapOffsetsInfo.
* Shared/WebCoreArgumentCoders.h: Added EnumTraits for ScrollSnapStrictness.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (277361 => 277362)
--- trunk/Source/WebKit/ChangeLog 2021-05-12 08:05:19 UTC (rev 277361)
+++ trunk/Source/WebKit/ChangeLog 2021-05-12 08:09:06 UTC (rev 277362)
@@ -1,3 +1,18 @@
+2021-05-12 Martin Robinson <[email protected]>
+
+ REGRESSION(r277083): Proximity scroll snap is broken on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=225649
+
+ Reviewed by Simon Fraser.
+
+ No new tests. iOS does not have great support for the event sending test
+ infrastructure used to test scroll snap.
+
+ * Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
+ (ArgumentCoder<FloatScrollSnapOffsetsInfo>::encode): Include the snap type when encoding ScrollSnapOffsetsInfo.
+ (ArgumentCoder<FloatScrollSnapOffsetsInfo>::decode): Include the snap type when decoding ScrollSnapOffsetsInfo.
+ * Shared/WebCoreArgumentCoders.h: Added EnumTraits for ScrollSnapStrictness.
+
2021-05-11 Chris Dumez <[email protected]>
Port WTF::FileSystem::listDirectory to std::filesystem
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp (277361 => 277362)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp 2021-05-12 08:05:19 UTC (rev 277361)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp 2021-05-12 08:09:06 UTC (rev 277362)
@@ -550,6 +550,7 @@
{
encoder << info.horizontalSnapOffsets;
encoder << info.verticalSnapOffsets;
+ encoder << info.strictness;
encoder << info.snapAreas;
}
@@ -559,6 +560,8 @@
return false;
if (!decoder.decode(info.verticalSnapOffsets))
return false;
+ if (!decoder.decode(info.strictness))
+ return false;
if (!decoder.decode(info.snapAreas))
return false;
return true;
Modified: trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h (277361 => 277362)
--- trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h 2021-05-12 08:05:19 UTC (rev 277361)
+++ trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h 2021-05-12 08:09:06 UTC (rev 277362)
@@ -1012,4 +1012,13 @@
};
#endif
+template<> struct EnumTraits<WebCore::ScrollSnapStrictness> {
+ using values = EnumValues<
+ WebCore::ScrollSnapStrictness,
+ WebCore::ScrollSnapStrictness::None,
+ WebCore::ScrollSnapStrictness::Proximity,
+ WebCore::ScrollSnapStrictness::Mandatory
+ >;
+};
+
} // namespace WTF
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
