Title: [277380] trunk/Source/WebKit
- Revision
- 277380
- Author
- [email protected]
- Date
- 2021-05-12 11:28:25 -0700 (Wed, 12 May 2021)
Log Message
Unreviewed follow-up to r277376.
Fix bad early return in NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision().
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (277379 => 277380)
--- trunk/Source/WebKit/ChangeLog 2021-05-12 18:00:23 UTC (rev 277379)
+++ trunk/Source/WebKit/ChangeLog 2021-05-12 18:28:25 UTC (rev 277380)
@@ -1,5 +1,14 @@
2021-05-12 Chris Dumez <[email protected]>
+ Unreviewed follow-up to r277376.
+
+ Fix bad early return in NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision().
+
+ * WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
+ (WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):
+
+2021-05-12 Chris Dumez <[email protected]>
+
Queue notification permission requests for the same origin on WebKit side
https://bugs.webkit.org/show_bug.cgi?id=225701
<rdar://76804977>
Modified: trunk/Source/WebKit/WebProcess/Notifications/NotificationPermissionRequestManager.cpp (277379 => 277380)
--- trunk/Source/WebKit/WebProcess/Notifications/NotificationPermissionRequestManager.cpp 2021-05-12 18:00:23 UTC (rev 277379)
+++ trunk/Source/WebKit/WebProcess/Notifications/NotificationPermissionRequestManager.cpp 2021-05-12 18:28:25 UTC (rev 277380)
@@ -134,9 +134,8 @@
auto callbacks = m_requestsPerOrigin.take(origin);
for (auto& callback : callbacks) {
- if (!callback)
- return;
- callback->handleEvent(allowed ? NotificationClient::Permission::Granted : NotificationClient::Permission::Denied);
+ if (callback)
+ callback->handleEvent(allowed ? NotificationClient::Permission::Granted : NotificationClient::Permission::Denied);
}
#else
UNUSED_PARAM(requestID);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
