Title: [277418] trunk/Source/WebCore
Revision
277418
Author
[email protected]
Date
2021-05-12 19:59:05 -0700 (Wed, 12 May 2021)

Log Message

Some webgl/2.0.0/conformance/textures/image_bitmap_from_image_data tests are failing after r277369 if !USE(ACCELERATE)
https://bugs.webkit.org/show_bug.cgi?id=225725

Reviewed by Sam Weinig.

* platform/graphics/PixelBufferConversion.cpp:
(WebCore::convertImagePixels): Fixed the wrong condition of destination.alphaFormat.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (277417 => 277418)


--- trunk/Source/WebCore/ChangeLog	2021-05-13 02:35:32 UTC (rev 277417)
+++ trunk/Source/WebCore/ChangeLog	2021-05-13 02:59:05 UTC (rev 277418)
@@ -1,3 +1,13 @@
+2021-05-12  Fujii Hironori  <[email protected]>
+
+        Some webgl/2.0.0/conformance/textures/image_bitmap_from_image_data tests are failing after r277369 if !USE(ACCELERATE)
+        https://bugs.webkit.org/show_bug.cgi?id=225725
+
+        Reviewed by Sam Weinig.
+
+        * platform/graphics/PixelBufferConversion.cpp:
+        (WebCore::convertImagePixels): Fixed the wrong condition of destination.alphaFormat.
+
 2021-05-12  Chris Dumez  <[email protected]>
 
         ASSERTION FAILED: actualVTablePointer == expectedVTablePointer in toJSNewlyCreated(JSC::JSGlobalObject *, WebCore::JSDOMGlobalObject *, Ref<WebCore::AudioNode> &&)

Modified: trunk/Source/WebCore/platform/graphics/PixelBufferConversion.cpp (277417 => 277418)


--- trunk/Source/WebCore/platform/graphics/PixelBufferConversion.cpp	2021-05-13 02:35:32 UTC (rev 277417)
+++ trunk/Source/WebCore/platform/graphics/PixelBufferConversion.cpp	2021-05-13 02:59:05 UTC (rev 277418)
@@ -204,7 +204,7 @@
             else
                 convertImagePixelsUnaccelerated<convertSinglePixelUnpremultipliedToUnpremultiplied<PixelFormatConversion::None>>(source, destination, destinationSize);
         } else {
-            if (destination.alphaFormat == AlphaPremultiplication::Unpremultiplied)
+            if (destination.alphaFormat == AlphaPremultiplication::Premultiplied)
                 convertImagePixelsUnaccelerated<convertSinglePixelPremultipliedToPremultiplied<PixelFormatConversion::Permute>>(source, destination, destinationSize);
             else
                 convertImagePixelsUnaccelerated<convertSinglePixelUnpremultipliedToUnpremultiplied<PixelFormatConversion::Permute>>(source, destination, destinationSize);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to