Title: [277476] trunk/Tools
- Revision
- 277476
- Author
- [email protected]
- Date
- 2021-05-13 19:06:04 -0700 (Thu, 13 May 2021)
Log Message
report-non-inclusive-language should skip symlinks
https://bugs.webkit.org/show_bug.cgi?id=225789
Reviewed by Darin Adler.
* Scripts/report-non-inclusive-language: Skip symlinks since most likely the linked file would be checked
directly by the script while iterating the directory structure and would result in it being counted twice.
Also the script fails with an error if there is a symlink pointing to a non-existing file.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (277475 => 277476)
--- trunk/Tools/ChangeLog 2021-05-14 02:03:43 UTC (rev 277475)
+++ trunk/Tools/ChangeLog 2021-05-14 02:06:04 UTC (rev 277476)
@@ -1,5 +1,16 @@
2021-05-13 Aakash Jain <[email protected]>
+ report-non-inclusive-language should skip symlinks
+ https://bugs.webkit.org/show_bug.cgi?id=225789
+
+ Reviewed by Darin Adler.
+
+ * Scripts/report-non-inclusive-language: Skip symlinks since most likely the linked file would be checked
+ directly by the script while iterating the directory structure and would result in it being counted twice.
+ Also the script fails with an error if there is a symlink pointing to a non-existing file.
+
+2021-05-13 Aakash Jain <[email protected]>
+
[ews] Style fixes in steps.py
https://bugs.webkit.org/show_bug.cgi?id=225784
Modified: trunk/Tools/Scripts/report-non-inclusive-language (277475 => 277476)
--- trunk/Tools/Scripts/report-non-inclusive-language 2021-05-14 02:03:43 UTC (rev 277475)
+++ trunk/Tools/Scripts/report-non-inclusive-language 2021-05-14 02:06:04 UTC (rev 277476)
@@ -67,6 +67,8 @@
continue
if file in IGNORE_FILE_NAMES:
continue
+ if os.path.islink(os.path.join(subroot, file)):
+ continue
handle = open(os.path.join(subroot, file), "r")
for line in handle.readlines():
for term in nonInclusiveTerms:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
