Title: [277516] trunk/Source/WebCore
Revision
277516
Author
[email protected]
Date
2021-05-14 16:20:16 -0700 (Fri, 14 May 2021)

Log Message

[showRenderTree] Do not integral floor the overflow values
https://bugs.webkit.org/show_bug.cgi?id=225825

Reviewed by Simon Fraser.

Integral flooring may hide fractional values caused by rounding bugs.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::outputRenderObject const):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (277515 => 277516)


--- trunk/Source/WebCore/ChangeLog	2021-05-14 23:12:12 UTC (rev 277515)
+++ trunk/Source/WebCore/ChangeLog	2021-05-14 23:20:16 UTC (rev 277516)
@@ -1,3 +1,15 @@
+2021-05-14  Alan Bujtas  <[email protected]>
+
+        [showRenderTree] Do not integral floor the overflow values
+        https://bugs.webkit.org/show_bug.cgi?id=225825
+
+        Reviewed by Simon Fraser.
+
+        Integral flooring may hide fractional values caused by rounding bugs.
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::outputRenderObject const):
+
 2021-05-14  Chris Dumez  <[email protected]>
 
         Drop "get" prefix from WTF::FileSystem's getFileModificationTime() / getFileCreationTime()

Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (277515 => 277516)


--- trunk/Source/WebCore/rendering/RenderObject.cpp	2021-05-14 23:12:12 UTC (rev 277515)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp	2021-05-14 23:20:16 UTC (rev 277516)
@@ -1225,11 +1225,11 @@
         const auto& box = downcast<RenderBox>(*this);
         if (box.hasRenderOverflow()) {
             auto layoutOverflow = box.layoutOverflowRect();
-            stream << " (layout overflow " << layoutOverflow.x().toInt() << "," << layoutOverflow.y().toInt() << " " << layoutOverflow.width().toInt() << "x" << layoutOverflow.height().toInt() << ")";
+            stream << " (layout overflow " << layoutOverflow.x() << "," << layoutOverflow.y() << " " << layoutOverflow.width() << "x" << layoutOverflow.height() << ")";
             
             if (box.hasVisualOverflow()) {
                 auto visualOverflow = box.visualOverflowRect();
-                stream << " (visual overflow " << visualOverflow.x().toInt() << "," << visualOverflow.y().toInt() << " " << visualOverflow.width().toInt() << "x" << visualOverflow.height().toInt() << ")";
+                stream << " (visual overflow " << visualOverflow.x() << "," << visualOverflow.y() << " " << visualOverflow.width() << "x" << visualOverflow.height() << ")";
             }
         }
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to