Title: [277650] trunk
- Revision
- 277650
- Author
- [email protected]
- Date
- 2021-05-18 06:23:44 -0700 (Tue, 18 May 2021)
Log Message
Difficult to scroll calcalist.co.il webpage, scrolling gets 'stuck'
https://bugs.webkit.org/show_bug.cgi?id=225905
<rdar://77692680>
Reviewed by Simon Fraser.
Source/WebCore:
The (implicit) integral flooring on the line height may produce short containing block for the inline content.
Test: fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
LayoutTests:
* fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow-expected.txt: Added.
* fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (277649 => 277650)
--- trunk/LayoutTests/ChangeLog 2021-05-18 11:27:54 UTC (rev 277649)
+++ trunk/LayoutTests/ChangeLog 2021-05-18 13:23:44 UTC (rev 277650)
@@ -1,3 +1,14 @@
+2021-05-18 Alan Bujtas <[email protected]>
+
+ Difficult to scroll calcalist.co.il webpage, scrolling gets 'stuck'
+ https://bugs.webkit.org/show_bug.cgi?id=225905
+ <rdar://77692680>
+
+ Reviewed by Simon Fraser.
+
+ * fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow-expected.txt: Added.
+ * fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow.html: Added.
+
2021-05-18 Cameron McCormack <[email protected]>
Test expectation updates from bug 225728
Added: trunk/LayoutTests/fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow-expected.txt (0 => 277650)
--- trunk/LayoutTests/fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow-expected.txt 2021-05-18 13:23:44 UTC (rev 277650)
@@ -0,0 +1 @@
+101
Added: trunk/LayoutTests/fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow.html (0 => 277650)
--- trunk/LayoutTests/fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow.html (rev 0)
+++ trunk/LayoutTests/fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow.html 2021-05-18 13:23:44 UTC (rev 277650)
@@ -0,0 +1,20 @@
+<style>
+#container {
+ overflow-y: hidden;
+}
+
+.inline {
+ border-top: 0.5px solid green;
+ background-color: red;
+ width: 100px;
+ height: 100px;
+ display: inline-block;
+ vertical-align: top;
+}
+</style><div id=container><div class=inline></div></div>
+<pre id=result></pre>
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+result.innerText = container.offsetHeight;
+</script>
Modified: trunk/Source/WebCore/ChangeLog (277649 => 277650)
--- trunk/Source/WebCore/ChangeLog 2021-05-18 11:27:54 UTC (rev 277649)
+++ trunk/Source/WebCore/ChangeLog 2021-05-18 13:23:44 UTC (rev 277650)
@@ -1,3 +1,18 @@
+2021-05-18 Alan Bujtas <[email protected]>
+
+ Difficult to scroll calcalist.co.il webpage, scrolling gets 'stuck'
+ https://bugs.webkit.org/show_bug.cgi?id=225905
+ <rdar://77692680>
+
+ Reviewed by Simon Fraser.
+
+ The (implicit) integral flooring on the line height may produce short containing block for the inline content.
+
+ Test: fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow.html
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
+
2021-05-18 Frederic Wang <[email protected]>
Use RefPtr for local ref counted objects of FrameSelection::setSelectionWithoutUpdatingAppearance
Modified: trunk/Source/WebCore/rendering/InlineFlowBox.cpp (277649 => 277650)
--- trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2021-05-18 11:27:54 UTC (rev 277649)
+++ trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2021-05-18 13:23:44 UTC (rev 277650)
@@ -508,7 +508,7 @@
continue; // Positioned placeholders don't affect calculations.
if ((child->verticalAlign() == VerticalAlign::Top || child->verticalAlign() == VerticalAlign::Bottom) && verticalAlignApplies(child->renderer())) {
- int lineHeight = child->lineHeight();
+ auto lineHeight = child->lineHeight();
if (child->verticalAlign() == VerticalAlign::Top) {
if (maxAscent + maxDescent < lineHeight)
maxDescent = lineHeight - maxAscent;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
