Title: [277748] trunk
- Revision
- 277748
- Author
- [email protected]
- Date
- 2021-05-19 13:49:25 -0700 (Wed, 19 May 2021)
Log Message
Fix typo in AirUseCounts
https://bugs.webkit.org/show_bug.cgi?id=225977
rdar://78210501
Reviewed by Mark Lam.
JSTests:
Add the testcase found by Tuomas.
* stress/register-allocator-stress.js: Added.
(foo):
Source/_javascript_Core:
I had just messed up a copy-and-paste, using "gp" instead of "fp" in code that deals with floating point values.
This did not show in my tests, probably because few functions have more floating point temporaries than non-floating-point.
* b3/air/AirUseCounts.h:
(JSC::B3::Air::UseCounts::UseCounts):
Modified Paths
Added Paths
Diff
Modified: trunk/JSTests/ChangeLog (277747 => 277748)
--- trunk/JSTests/ChangeLog 2021-05-19 20:30:27 UTC (rev 277747)
+++ trunk/JSTests/ChangeLog 2021-05-19 20:49:25 UTC (rev 277748)
@@ -1,3 +1,16 @@
+2021-05-19 Robin Morisset <[email protected]>
+
+ Fix typo in AirUseCounts
+ https://bugs.webkit.org/show_bug.cgi?id=225977
+ rdar://78210501
+
+ Reviewed by Mark Lam.
+
+ Add the testcase found by Tuomas.
+
+ * stress/register-allocator-stress.js: Added.
+ (foo):
+
2021-05-18 Keith Miller <[email protected]>
Temporarily revert r276592 as it breaks some native apps
Added: trunk/JSTests/stress/register-allocator-stress.js (0 => 277748)
--- trunk/JSTests/stress/register-allocator-stress.js (rev 0)
+++ trunk/JSTests/stress/register-allocator-stress.js 2021-05-19 20:49:25 UTC (rev 277748)
@@ -0,0 +1,169 @@
+//@ requireOptions("--seedOfVMRandomForFuzzer=2539143341", "--useWideningNumberPredictionFuzzerAgent=1", "--jitPolicyScale=0")
+
+function foo(o) {
+ let result = 0;
+ for (let i = 0; i < 52; ++i) {
+ let value = i | 0;
+ switch (value) {
+ case 0:
+ result += o?.a;
+ break;
+ case 1:
+ result += o?.b;
+ break;
+ case 2:
+ result += o.c;
+ break;
+ case 3:
+ result += o.d;
+ break;
+ case 4:
+ result += o.e;
+ break;
+ case 5:
+ result += o.f;
+ break;
+ case 6:
+ result += o.g;
+ break;
+ case 7:
+ result += o.h;
+ break;
+ case 8:
+ result += o.i;
+ break;
+ case 9:
+ result += o.j;
+ break;
+ case 10:
+ result += o.k;
+ break;
+ case 11:
+ result += o.a;
+ break;
+ case 12:
+ result += o.b;
+ break;
+ case 13:
+ result += o.c;
+ break;
+ case 14:
+ result += o.d;
+ break;
+ case 15:
+ result += o.e;
+ break;
+ case 16:
+ result += o.f;
+ break;
+ case 17:
+ result += o.g;
+ break;
+ case 18:
+ result += o.h;
+ break;
+ case 19:
+ result += o.i;
+ break;
+ case 20:
+ result += o.j;
+ break;
+ case 21:
+ result += o.k;
+ break;
+ case 22:
+ result += o.a;
+ break;
+ case 23:
+ result += o.a;
+ break;
+ case 24:
+ result += o.b;
+ break;
+ case 25:
+ result += o.c;
+ break;
+ case 26:
+ result += o.d;
+ break;
+ case 27:
+ result += o.e;
+ break;
+ case 28:
+ result += o.f;
+ break;
+ case 29:
+ result += o.g;
+ break;
+ case 30:
+ result += o.h;
+ break;
+ case 31:
+ result += o.i;
+ break;
+ case 32:
+ result += o.j;
+ break;
+ case 33:
+ result += o.k;
+ break;
+ case 34:
+ result += o.l;
+ break;
+ case 36:
+ result += o.a;
+ break;
+ case 37:
+ result += o.b;
+ break;
+ case 38:
+ result += o.c;
+ break;
+ case 39:
+ result += o.d;
+ break;
+ case 40:
+ result += o.e;
+ break;
+ case 41:
+ result += o.f;
+ break;
+ case 42:
+ result += o.g;
+ break;
+ case 43:
+ result += o.h;
+ break;
+ case 44:
+ result += o.i;
+ break;
+ case 45:
+ result += o.j;
+ break;
+ case 46:
+ result += o.k;
+ break;
+ case 47:
+ result += o.a;
+ break;
+ case 48:
+ result += o.b;
+ break;
+ case 49:
+ result += o.c;
+ break;
+ case 50:
+ result += o.d;
+ break;
+ case 51:
+ result += o.e;
+ break;
+ }
+ }
+ return result;
+}
+
+let o = {a: 0, b: 0, c: 0, d: 0, e: 0, f: 0, g: 0, h: 0, i: 0, j: 0, k: 0, l: 0};
+for (let i = 0; i < 100000; ++i) {
+ foo(o);
+}
Modified: trunk/Source/_javascript_Core/ChangeLog (277747 => 277748)
--- trunk/Source/_javascript_Core/ChangeLog 2021-05-19 20:30:27 UTC (rev 277747)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-05-19 20:49:25 UTC (rev 277748)
@@ -1,3 +1,17 @@
+2021-05-19 Robin Morisset <[email protected]>
+
+ Fix typo in AirUseCounts
+ https://bugs.webkit.org/show_bug.cgi?id=225977
+ rdar://78210501
+
+ Reviewed by Mark Lam.
+
+ I had just messed up a copy-and-paste, using "gp" instead of "fp" in code that deals with floating point values.
+ This did not show in my tests, probably because few functions have more floating point temporaries than non-floating-point.
+
+ * b3/air/AirUseCounts.h:
+ (JSC::B3::Air::UseCounts::UseCounts):
+
2021-05-18 Darin Adler <[email protected]>
Move CFStringRef and NSString support from StringBuilder into StringConcatenateCF
Modified: trunk/Source/_javascript_Core/b3/air/AirUseCounts.h (277747 => 277748)
--- trunk/Source/_javascript_Core/b3/air/AirUseCounts.h 2021-05-19 20:30:27 UTC (rev 277747)
+++ trunk/Source/_javascript_Core/b3/air/AirUseCounts.h 2021-05-19 20:49:25 UTC (rev 277748)
@@ -60,7 +60,7 @@
m_gpConstDefs.ensureSize(gpArraySize);
unsigned fpArraySize = AbsoluteTmpMapper<FP>::absoluteIndex(code.numTmps(FP));
m_fpNumWarmUsesAndDefs.resize(fpArraySize);
- m_fpConstDefs.ensureSize(gpArraySize);
+ m_fpConstDefs.ensureSize(fpArraySize);
for (BasicBlock* block : code) {
double frequency = block->frequency();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
