Title: [277789] trunk/Source/WebCore
Revision
277789
Author
[email protected]
Date
2021-05-20 09:13:29 -0700 (Thu, 20 May 2021)

Log Message

AirPlay icon of the Vimeo.com video player is missing after reloading the page
https://bugs.webkit.org/show_bug.cgi?id=226005

Reviewed by Eric Carlson.

Some sites, e.g., vimeo.com, depends on the "webkitplaybacktargetavailabilitychanged"
event to setup the player related to AirPlay feature properly. When we reload a
page including media element(s), the element's media session will be constructed
with `m_hasPlaybackTargets` be `true`, so no "webkitplaybacktargetavailabilitychanged"
event will be fired.

This patch ensures that an `HTMLMediaElement` always fires that event when we
reload the page.

* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::MediaElementSession):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (277788 => 277789)


--- trunk/Source/WebCore/ChangeLog	2021-05-20 16:12:49 UTC (rev 277788)
+++ trunk/Source/WebCore/ChangeLog	2021-05-20 16:13:29 UTC (rev 277789)
@@ -1,5 +1,24 @@
 2021-05-20  Peng Liu  <[email protected]>
 
+        AirPlay icon of the Vimeo.com video player is missing after reloading the page
+        https://bugs.webkit.org/show_bug.cgi?id=226005
+
+        Reviewed by Eric Carlson.
+
+        Some sites, e.g., vimeo.com, depends on the "webkitplaybacktargetavailabilitychanged"
+        event to setup the player related to AirPlay feature properly. When we reload a
+        page including media element(s), the element's media session will be constructed
+        with `m_hasPlaybackTargets` be `true`, so no "webkitplaybacktargetavailabilitychanged"
+        event will be fired.
+
+        This patch ensures that an `HTMLMediaElement` always fires that event when we
+        reload the page.
+
+        * html/MediaElementSession.cpp:
+        (WebCore::MediaElementSession::MediaElementSession):
+
+2021-05-20  Peng Liu  <[email protected]>
+
         AirPlay icon of the Vimeo.com video player is missing
         https://bugs.webkit.org/show_bug.cgi?id=226004
 

Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (277788 => 277789)


--- trunk/Source/WebCore/html/MediaElementSession.cpp	2021-05-20 16:12:49 UTC (rev 277788)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp	2021-05-20 16:13:29 UTC (rev 277789)
@@ -162,7 +162,6 @@
     , m_restrictions(NoRestrictions)
 #if ENABLE(WIRELESS_PLAYBACK_TARGET)
     , m_targetAvailabilityChangedTimer(*this, &MediaElementSession::targetAvailabilityChangedTimerFired)
-    , m_hasPlaybackTargets(manager().hasWirelessTargetsAvailable())
 #endif
     , m_mainContentCheckTimer(*this, &MediaElementSession::mainContentCheckTimerFired)
     , m_clientDataBufferingTimer(*this, &MediaElementSession::clientDataBufferingTimerFired)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to