Title: [277846] trunk/Source/WebKit
- Revision
- 277846
- Author
- [email protected]
- Date
- 2021-05-20 19:37:42 -0700 (Thu, 20 May 2021)
Log Message
[iOS][FCR] <select> options are unnecessarily truncated
https://bugs.webkit.org/show_bug.cgi?id=226048
<rdar://problem/76008154>
Reviewed by Tim Horton.
* UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPicker createMenu]):
UIMenu's currently limit action titles to two lines. Use SPI to remove
the limit and avoid unnecessary truncation.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (277845 => 277846)
--- trunk/Source/WebKit/ChangeLog 2021-05-21 02:21:09 UTC (rev 277845)
+++ trunk/Source/WebKit/ChangeLog 2021-05-21 02:37:42 UTC (rev 277846)
@@ -1,3 +1,17 @@
+2021-05-20 Aditya Keerthi <[email protected]>
+
+ [iOS][FCR] <select> options are unnecessarily truncated
+ https://bugs.webkit.org/show_bug.cgi?id=226048
+ <rdar://problem/76008154>
+
+ Reviewed by Tim Horton.
+
+ * UIProcess/ios/forms/WKFormSelectPicker.mm:
+ (-[WKSelectPicker createMenu]):
+
+ UIMenu's currently limit action titles to two lines. Use SPI to remove
+ the limit and avoid unnecessary truncation.
+
2021-05-20 Alex Christensen <[email protected]>
Unreviewed, reverting r277606.
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm (277845 => 277846)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm 2021-05-21 02:21:09 UTC (rev 277845)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm 2021-05-21 02:37:42 UTC (rev 277846)
@@ -473,6 +473,9 @@
#pragma mark - Form Control Refresh
+// FIXME: Remove once <rdar://problem/76430376> is in an SDK.
+#define UIMenuOptionsPrivateRemoveLineLimitForChildren (1 << 6)
+
@implementation WKSelectPicker {
__weak WKContentView *_view;
CGPoint _interactionPoint;
@@ -582,7 +585,7 @@
currentIndex++;
}
- UIMenu *groupMenu = [UIMenu menuWithTitle:groupText image:nil identifier:nil options:UIMenuOptionsDisplayInline children:groupedItems];
+ UIMenu *groupMenu = [UIMenu menuWithTitle:groupText image:nil identifier:nil options:(UIMenuOptionsDisplayInline | UIMenuOptionsPrivateRemoveLineLimitForChildren) children:groupedItems];
[items addObject:groupMenu];
continue;
}
@@ -593,7 +596,7 @@
currentIndex++;
}
- return [UIMenu menuWithTitle:@"" children:items];
+ return [UIMenu menuWithTitle:@"" image:nil identifier:nil options:UIMenuOptionsPrivateRemoveLineLimitForChildren children:items];
}
- (UIAction *)actionForOptionItem:(const OptionItem&)option withIndex:(NSInteger)optionIndex
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
