Title: [278125] trunk
- Revision
- 278125
- Author
- tsav...@apple.com
- Date
- 2021-05-26 14:19:14 -0700 (Wed, 26 May 2021)
Log Message
Unreviewed, reverting r278028.
Caused fast/selectors/slow-style-sharing-with-long-cousin-
list.html to timeout on iOS and Windows.
Reverted changeset:
"CrashOnOverflow in
WebCore::RenderTable::cellBefore(WebCore::RenderTableCell
const*)"
https://bugs.webkit.org/show_bug.cgi?id=225949
https://commits.webkit.org/r278028
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (278124 => 278125)
--- trunk/LayoutTests/ChangeLog 2021-05-26 21:05:17 UTC (rev 278124)
+++ trunk/LayoutTests/ChangeLog 2021-05-26 21:19:14 UTC (rev 278125)
@@ -1,3 +1,18 @@
+2021-05-26 Truitt Savell <tsav...@apple.com>
+
+ Unreviewed, reverting r278028.
+
+ Caused fast/selectors/slow-style-sharing-with-long-cousin-
+ list.html to timeout on iOS and Windows.
+
+ Reverted changeset:
+
+ "CrashOnOverflow in
+ WebCore::RenderTable::cellBefore(WebCore::RenderTableCell
+ const*)"
+ https://bugs.webkit.org/show_bug.cgi?id=225949
+ https://commits.webkit.org/r278028
+
2021-05-26 Chris Dumez <cdu...@apple.com>
Unreviewed, skip new WebAudio tests added in r278068 on Windows.
Deleted: trunk/LayoutTests/fast/table/table-split-on-insert-with-section-crash-expected.txt (278124 => 278125)
--- trunk/LayoutTests/fast/table/table-split-on-insert-with-section-crash-expected.txt 2021-05-26 21:05:17 UTC (rev 278124)
+++ trunk/LayoutTests/fast/table/table-split-on-insert-with-section-crash-expected.txt 2021-05-26 21:19:14 UTC (rev 278125)
@@ -1,2 +0,0 @@
-
-
Deleted: trunk/LayoutTests/fast/table/table-split-on-insert-with-section-crash.html (278124 => 278125)
--- trunk/LayoutTests/fast/table/table-split-on-insert-with-section-crash.html 2021-05-26 21:05:17 UTC (rev 278124)
+++ trunk/LayoutTests/fast/table/table-split-on-insert-with-section-crash.html 2021-05-26 21:19:14 UTC (rev 278125)
@@ -1,34 +0,0 @@
-<!DOCTYPE html>
-<style>
- body {
- border-collapse: collapse;
- }
-
- :read-write::after {
- content: '';
- }
- :first-child::first-letter {
- background: grey;
- }
-</style>
-<script>
-if (window.testRunner)
- testRunner.dumpAsText();
-
-_onload_ = () => {
- document.documentElement.appendChild(document.createElement('input'));
- document.execCommand('SelectAll');
- document.execCommand('Copy');
- let aElement = document.createElement('a');
- document.body.appendChild(aElement);
- let row = document.createElement('tr');
- aElement.appendChild(row);
- row.appendChild(document.createElement('input'));
- row.appendChild(document.createElement('td'));
- getSelection().modify('move', 'left', 'sentenceboundary');
- document.designMode = 'on';
- document.execCommand('PasteAsQuotation');
- document.styleSheets[0].insertRule(`#nnn {}`);
-};
-</script>
-<!-- Pass if no crash or assert. -->
Modified: trunk/Source/WebCore/ChangeLog (278124 => 278125)
--- trunk/Source/WebCore/ChangeLog 2021-05-26 21:05:17 UTC (rev 278124)
+++ trunk/Source/WebCore/ChangeLog 2021-05-26 21:19:14 UTC (rev 278125)
@@ -1,3 +1,18 @@
+2021-05-26 Truitt Savell <tsav...@apple.com>
+
+ Unreviewed, reverting r278028.
+
+ Caused fast/selectors/slow-style-sharing-with-long-cousin-
+ list.html to timeout on iOS and Windows.
+
+ Reverted changeset:
+
+ "CrashOnOverflow in
+ WebCore::RenderTable::cellBefore(WebCore::RenderTableCell
+ const*)"
+ https://bugs.webkit.org/show_bug.cgi?id=225949
+ https://commits.webkit.org/r278028
+
2021-05-26 Wenson Hsieh <wenson_hs...@apple.com>
[macOS] Support painting data detector highlights inside image overlays
Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (278124 => 278125)
--- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2021-05-26 21:05:17 UTC (rev 278124)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2021-05-26 21:19:14 UTC (rev 278125)
@@ -123,7 +123,8 @@
void RenderTableSection::willInsertTableRow(RenderTableRow& child, RenderObject* beforeChild)
{
- setNeedsCellRecalc();
+ if (beforeChild)
+ setNeedsCellRecalc();
unsigned insertionRow = m_cRow;
++m_cRow;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
