Title: [278139] trunk/Source/_javascript_Core
- Revision
- 278139
- Author
- tzaga...@apple.com
- Date
- 2021-05-26 17:36:06 -0700 (Wed, 26 May 2021)
Log Message
REGRESSION: ASSERTION FAILED: !isCompilationThread() in JSC::Profiler::Database::addCompilation()
https://bugs.webkit.org/show_bug.cgi?id=226302
<rdar://78537378>
Reviewed by Saam Barati.
We started linking the JIT code in the compiler thread, which now triggers this assertion.
The assertion was introduce before a lock was held to modify the data structures in the
profiler database, but it's safe to remove it now.
* profiler/ProfilerDatabase.cpp:
(JSC::Profiler::Database::addCompilation):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (278138 => 278139)
--- trunk/Source/_javascript_Core/ChangeLog 2021-05-27 00:35:38 UTC (rev 278138)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-05-27 00:36:06 UTC (rev 278139)
@@ -1,3 +1,18 @@
+2021-05-26 Tadeu Zagallo <tzaga...@apple.com>
+
+ REGRESSION: ASSERTION FAILED: !isCompilationThread() in JSC::Profiler::Database::addCompilation()
+ https://bugs.webkit.org/show_bug.cgi?id=226302
+ <rdar://78537378>
+
+ Reviewed by Saam Barati.
+
+ We started linking the JIT code in the compiler thread, which now triggers this assertion.
+ The assertion was introduce before a lock was held to modify the data structures in the
+ profiler database, but it's safe to remove it now.
+
+ * profiler/ProfilerDatabase.cpp:
+ (JSC::Profiler::Database::addCompilation):
+
2021-05-26 Chris Dumez <cdu...@apple.com>
Use UncheckedLock even less in _javascript_Core
Modified: trunk/Source/_javascript_Core/profiler/ProfilerDatabase.cpp (278138 => 278139)
--- trunk/Source/_javascript_Core/profiler/ProfilerDatabase.cpp 2021-05-27 00:35:38 UTC (rev 278138)
+++ trunk/Source/_javascript_Core/profiler/ProfilerDatabase.cpp 2021-05-27 00:36:06 UTC (rev 278139)
@@ -89,7 +89,6 @@
void Database::addCompilation(CodeBlock* codeBlock, Ref<Compilation>&& compilation)
{
Locker locker { m_lock };
- ASSERT(!isCompilationThread());
m_compilations.append(compilation.copyRef());
m_compilationMap.set(codeBlock, WTFMove(compilation));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
