Title: [278252] trunk/Tools
- Revision
- 278252
- Author
- [email protected]
- Date
- 2021-05-30 04:43:49 -0700 (Sun, 30 May 2021)
Log Message
REGRESSION (r274460): [macOS] TestWebKitAPI.Fullscreen.WKViewDelegate is timing out
https://bugs.webkit.org/show_bug.cgi?id=223282
rdar://75495585
Reviewed by Darin Adler.
Remove WKViewDelegate test. This test specifically tests the old, C-API
delegate callback that’s not exposed as API and no one uses. This feature
is explicitly deprecated and no-one uses it.
* TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm: Delete test
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (278251 => 278252)
--- trunk/Tools/ChangeLog 2021-05-30 06:51:57 UTC (rev 278251)
+++ trunk/Tools/ChangeLog 2021-05-30 11:43:49 UTC (rev 278252)
@@ -1,3 +1,17 @@
+2021-05-30 Jean-Yves Avenard <[email protected]>
+
+ REGRESSION (r274460): [macOS] TestWebKitAPI.Fullscreen.WKViewDelegate is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=223282
+ rdar://75495585
+
+ Reviewed by Darin Adler.
+
+ Remove WKViewDelegate test. This test specifically tests the old, C-API
+ delegate callback that’s not exposed as API and no one uses. This feature
+ is explicitly deprecated and no-one uses it.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm: Delete test
+
2021-05-29 Ryan Haddad <[email protected]>
[webkitpy] Add a delay between successive iOS simulator boots
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm (278251 => 278252)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm 2021-05-30 06:51:57 UTC (rev 278251)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm 2021-05-30 11:43:49 UTC (rev 278252)
@@ -43,11 +43,6 @@
static bool receivedWillExitFullscreenMessage;
static bool receivedDidExitFullscreenMessage;
-static void didFinishNavigation(WKPageRef, WKNavigationRef, WKTypeRef, const void*)
-{
- receivedLoadedMessage = true;
-}
-
@interface FullscreenDelegateMessageHandler : NSObject <WKScriptMessageHandler, _WKFullscreenDelegate>
@end
@@ -114,52 +109,6 @@
ASSERT_FALSE([webView _isInFullscreen]);
}
-TEST(Fullscreen, WKViewDelegate)
-{
- WKRetainPtr<WKContextRef> context = adoptWK(WKContextCreateWithConfiguration(nullptr));
- WKRetainPtr<WKPageGroupRef> pageGroup = adoptWK(WKPageGroupCreateWithIdentifier(Util::toWK("FullscreenDelegate").get()));
- WKPreferencesRef preferences = WKPageGroupGetPreferences(pageGroup.get());
- WKPreferencesSetFullScreenEnabled(preferences, true);
-
- WKRetainPtr<WKPageConfigurationRef> configuration = adoptWK(WKPageConfigurationCreate());
- WKPageConfigurationSetContext(configuration.get(), context.get());
- WKPageConfigurationSetPageGroup(configuration.get(), pageGroup.get());
-
- NSRect rect = NSMakeRect(0, 0, 800, 600);
- auto webView = adoptNS([[WKView alloc] initWithFrame:rect configurationRef:configuration.get()]);
- [webView setWindowOcclusionDetectionEnabled:NO];
-
- auto window = adoptNS([[NSWindow alloc] initWithContentRect:rect styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
- [[window contentView] addSubview:webView.get()];
- [window makeKeyAndOrderFront:nil];
-
- RetainPtr<FullscreenDelegateMessageHandler> handler = adoptNS([[FullscreenDelegateMessageHandler alloc] init]);
- WKPageSetFullscreenDelegate([webView pageRef], handler.get());
-
- WKPageNavigationClientV0 loaderClient;
- memset(&loaderClient, 0 , sizeof(loaderClient));
-
- loaderClient.base.version = 0;
- loaderClient.didFinishNavigation = didFinishNavigation;
- WKPageSetPageNavigationClient([webView pageRef], &loaderClient.base);
-
- receivedLoadedMessage = false;
- WKRetainPtr<WKURLRef> url = "" "html"));
- WKPageLoadURL([webView pageRef], url.get());
-
- TestWebKitAPI::Util::run(&receivedLoadedMessage);
-
- NSEvent *event = [NSEvent mouseEventWithType:NSEventTypeLeftMouseDown location:NSMakePoint(5, 5) modifierFlags:0 timestamp:0 windowNumber:window.get().windowNumber context:0 eventNumber:0 clickCount:0 pressure:0];
-
- [webView mouseDown:event];
- TestWebKitAPI::Util::run(&receivedWillEnterFullscreenMessage);
- TestWebKitAPI::Util::run(&receivedDidEnterFullscreenMessage);
-
- [webView mouseDown:event];
- TestWebKitAPI::Util::run(&receivedWillExitFullscreenMessage);
- TestWebKitAPI::Util::run(&receivedDidExitFullscreenMessage);
-}
-
} // namespace TestWebKitAPI
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
