Title: [278389] trunk/Source/WebCore
- Revision
- 278389
- Author
- [email protected]
- Date
- 2021-06-02 17:33:35 -0700 (Wed, 02 Jun 2021)
Log Message
Remove redundant isChildHitTestCandidate in RenderBlock::positionForPoint
https://bugs.webkit.org/show_bug.cgi?id=226554
<rdar://problem/78782485>
Reviewed by Simon Fraser.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPoint):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (278388 => 278389)
--- trunk/Source/WebCore/ChangeLog 2021-06-03 00:09:25 UTC (rev 278388)
+++ trunk/Source/WebCore/ChangeLog 2021-06-03 00:33:35 UTC (rev 278389)
@@ -1,5 +1,16 @@
2021-06-02 Alan Bujtas <[email protected]>
+ Remove redundant isChildHitTestCandidate in RenderBlock::positionForPoint
+ https://bugs.webkit.org/show_bug.cgi?id=226554
+ <rdar://problem/78782485>
+
+ Reviewed by Simon Fraser.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::positionForPoint):
+
+2021-06-02 Alan Bujtas <[email protected]>
+
Incorrect selection when tall float is present
https://bugs.webkit.org/show_bug.cgi?id=226552
<rdar://problem/78781056>
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (278388 => 278389)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2021-06-03 00:09:25 UTC (rev 278388)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2021-06-03 00:33:35 UTC (rev 278389)
@@ -2229,8 +2229,7 @@
if (is<RenderBlockFlow>(childBox))
childLogicalBottom = std::max(childLogicalBottom, downcast<RenderBlockFlow>(*childBox).lowestFloatLogicalBottom());
// We hit child if our click is above the bottom of its padding box (like IE6/7 and FF3).
- if (isChildHitTestCandidate(*childBox, fragment, pointInLogicalContents) && (pointInLogicalContents.y() < childLogicalBottom
- || (blocksAreFlipped && pointInLogicalContents.y() == childLogicalBottom)))
+ if (pointInLogicalContents.y() < childLogicalBottom || (blocksAreFlipped && pointInLogicalContents.y() == childLogicalBottom))
return positionForPointRespectingEditingBoundaries(*this, *childBox, pointInContents);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
