Title: [278415] trunk/Source/WebCore
Revision
278415
Author
[email protected]
Date
2021-06-03 12:40:39 -0700 (Thu, 03 Jun 2021)

Log Message

Do not recalibrate camera if the settings are the same
https://bugs.webkit.org/show_bug.cgi?id=226585

Reviewed by Eric Carlson.

Make sure to not update the preset if the constraints are equal to the current settings.
Manually tested.

* platform/mediastream/RealtimeVideoCaptureSource.cpp:
(WebCore::RealtimeVideoCaptureSource::clientUpdatedSizeAndFrameRate):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (278414 => 278415)


--- trunk/Source/WebCore/ChangeLog	2021-06-03 19:40:00 UTC (rev 278414)
+++ trunk/Source/WebCore/ChangeLog	2021-06-03 19:40:39 UTC (rev 278415)
@@ -1,3 +1,16 @@
+2021-06-03  Youenn Fablet  <[email protected]>
+
+        Do not recalibrate camera if the settings are the same
+        https://bugs.webkit.org/show_bug.cgi?id=226585
+
+        Reviewed by Eric Carlson.
+
+        Make sure to not update the preset if the constraints are equal to the current settings.
+        Manually tested.
+
+        * platform/mediastream/RealtimeVideoCaptureSource.cpp:
+        (WebCore::RealtimeVideoCaptureSource::clientUpdatedSizeAndFrameRate):
+
 2021-06-03  Alan Bujtas  <[email protected]>
 
         Incorrect text selection when crossing flex item boundary

Modified: trunk/Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp (278414 => 278415)


--- trunk/Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp	2021-06-03 19:40:00 UTC (rev 278414)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp	2021-06-03 19:40:39 UTC (rev 278415)
@@ -407,11 +407,11 @@
 {
     // FIXME: We only change settings if capture resolution is below requested one. We should get the best preset for all clients.
     auto& settings = this->settings();
-    if (width && *width < static_cast<int>(settings.width()))
+    if (width && *width <= static_cast<int>(settings.width()))
         width = { };
-    if (height && *height < static_cast<int>(settings.height()))
+    if (height && *height <= static_cast<int>(settings.height()))
         height = { };
-    if (frameRate && *frameRate < static_cast<double>(settings.frameRate()))
+    if (frameRate && *frameRate <= static_cast<double>(settings.frameRate()))
         frameRate = { };
 
     if (!width && !height && !frameRate)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to