Title: [278452] trunk
- Revision
- 278452
- Author
- [email protected]
- Date
- 2021-06-04 04:05:02 -0700 (Fri, 04 Jun 2021)
Log Message
[Win] Implement scroll-snap-points on Windows
https://bugs.webkit.org/show_bug.cgi?id=142503
<rdar://problem/20093603>
Reviewed by Simon Fraser.
.:
* Source/cmake/OptionsWin.cmake: Stop disabling scroll-snap for Apple Win port.
LayoutTests:
* platform/win/TestExpectations: Unskip scroll-snap tests.
* platform/win/css3/scroll-snap/scroll-snap-wheel-event-expected.txt: Added. Windows doesn't
seem to support horizontal wheel events.
Modified Paths
Added Paths
Diff
Modified: trunk/ChangeLog (278451 => 278452)
--- trunk/ChangeLog 2021-06-04 10:43:40 UTC (rev 278451)
+++ trunk/ChangeLog 2021-06-04 11:05:02 UTC (rev 278452)
@@ -1,3 +1,13 @@
+2021-06-04 Martin Robinson <[email protected]>
+
+ [Win] Implement scroll-snap-points on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=142503
+ <rdar://problem/20093603>
+
+ Reviewed by Simon Fraser.
+
+ * Source/cmake/OptionsWin.cmake: Stop disabling scroll-snap for Apple Win port.
+
2021-05-27 Don Olmstead <[email protected]>
[CMake] Add check for timingsafe_bcmp
Modified: trunk/LayoutTests/ChangeLog (278451 => 278452)
--- trunk/LayoutTests/ChangeLog 2021-06-04 10:43:40 UTC (rev 278451)
+++ trunk/LayoutTests/ChangeLog 2021-06-04 11:05:02 UTC (rev 278452)
@@ -1,3 +1,15 @@
+2021-06-04 Martin Robinson <[email protected]>
+
+ [Win] Implement scroll-snap-points on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=142503
+ <rdar://problem/20093603>
+
+ Reviewed by Simon Fraser.
+
+ * platform/win/TestExpectations: Unskip scroll-snap tests.
+ * platform/win/css3/scroll-snap/scroll-snap-wheel-event-expected.txt: Added. Windows doesn't
+ seem to support horizontal wheel events.
+
2021-06-03 Alan Bujtas <[email protected]>
Crack in hero text on https://www.apple.com/mac-mini/
Modified: trunk/LayoutTests/platform/win/TestExpectations (278451 => 278452)
--- trunk/LayoutTests/platform/win/TestExpectations 2021-06-04 10:43:40 UTC (rev 278451)
+++ trunk/LayoutTests/platform/win/TestExpectations 2021-06-04 11:05:02 UTC (rev 278452)
@@ -547,10 +547,6 @@
# TODO CSS Grid Layout is not yet enabled.
webkit.org/b/60731 fast/css-grid-layout/ [ Skip ]
-# TODO ENABLE(CSS_SCROLL_SNAP) is disabled.
-css3/scroll-snap/ [ Skip ]
-imported/w3c/web-platform-tests/css/css-scroll-snap [ Skip ]
-
# JSC does not support setIsolatedWorldSecurityOrigin
webkit.org/b/61540 http/tests/security/isolatedWorld/cross-origin-xhr.html [ Skip ]
Added: trunk/LayoutTests/platform/win/css3/scroll-snap/scroll-snap-wheel-event-expected.txt (0 => 278452)
--- trunk/LayoutTests/platform/win/css3/scroll-snap/scroll-snap-wheel-event-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/css3/scroll-snap/scroll-snap-wheel-event-expected.txt 2021-06-04 11:05:02 UTC (rev 278452)
@@ -0,0 +1,7 @@
+FAIL horizontal mouse wheel event snapped
+PASS vertical mouse wheel event snapped
+PASS successfullyParsed is true
+Some tests failed.
+
+TEST COMPLETE
+
Modified: trunk/Source/cmake/OptionsWin.cmake (278451 => 278452)
--- trunk/Source/cmake/OptionsWin.cmake 2021-06-04 10:43:40 UTC (rev 278451)
+++ trunk/Source/cmake/OptionsWin.cmake 2021-06-04 11:05:02 UTC (rev 278452)
@@ -91,7 +91,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE OFF)
else ()
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_COMPOSITING PUBLIC OFF)
- WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SCROLL_SNAP PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LEGACY_ENCRYPTED_MEDIA PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PUBLIC_SUFFIX_LIST PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE OFF)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
