Title: [278460] trunk/Tools
- Revision
- 278460
- Author
- [email protected]
- Date
- 2021-06-04 08:35:30 -0700 (Fri, 04 Jun 2021)
Log Message
The CMake cache is removed when specifying a build target
https://bugs.webkit.org/show_bug.cgi?id=226642
Reviewed by Jonathan Bedard.
* Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache): Only remove the CMake cache when arguments
that start with a dash change.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (278459 => 278460)
--- trunk/Tools/ChangeLog 2021-06-04 15:32:21 UTC (rev 278459)
+++ trunk/Tools/ChangeLog 2021-06-04 15:35:30 UTC (rev 278460)
@@ -1,3 +1,14 @@
+2021-06-04 Martin Robinson <[email protected]>
+
+ The CMake cache is removed when specifying a build target
+ https://bugs.webkit.org/show_bug.cgi?id=226642
+
+ Reviewed by Jonathan Bedard.
+
+ * Scripts/webkitdirs.pm:
+ (shouldRemoveCMakeCache): Only remove the CMake cache when arguments
+ that start with a dash change.
+
2021-06-04 Michael Catanzaro <[email protected]>
[GTK][WPE] Expose setCORSDisablingPatterns
Modified: trunk/Tools/Scripts/webkitdirs.pm (278459 => 278460)
--- trunk/Tools/Scripts/webkitdirs.pm 2021-06-04 15:32:21 UTC (rev 278459)
+++ trunk/Tools/Scripts/webkitdirs.pm 2021-06-04 15:35:30 UTC (rev 278460)
@@ -2365,7 +2365,10 @@
sub shouldRemoveCMakeCache(@)
{
- my (@buildArgs) = sort (@_, @originalArgv);
+ # For this check, ignore all arguments that do not begin with a dash. These
+ # are probably arguments specifying build targets. Changing those should
+ # not trigger a reconfiguration of the build.
+ my (@buildArgs) = grep(/^-/, sort(@_, @originalArgv));
# We check this first, because we always want to create this file for a fresh build.
my $productDir = File::Spec->catdir(baseProductDir(), configuration());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
