Title: [278471] trunk/Source/WebKit
- Revision
- 278471
- Author
- [email protected]
- Date
- 2021-06-04 10:14:24 -0700 (Fri, 04 Jun 2021)
Log Message
Avoid wasteful large allocation in SpeechRecognitionRemoteRealtimeMediaSource::setStorage()
https://bugs.webkit.org/show_bug.cgi?id=226644
Reviewed by Eric Carlson.
Avoid wasteful large allocation in SpeechRecognitionRemoteRealtimeMediaSource::setStorage().
setStorage() was setting m_buffer's size to the same size as the RingBuffer (2*sampleRate),
only to resize it to the size of the rendering quantum (512) later in
SpeechRecognitionRemoteRealtimeMediaSource::remoteAudioSamplesAvailable().
* UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:
(WebKit::SpeechRecognitionRemoteRealtimeMediaSource::setStorage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (278470 => 278471)
--- trunk/Source/WebKit/ChangeLog 2021-06-04 17:12:48 UTC (rev 278470)
+++ trunk/Source/WebKit/ChangeLog 2021-06-04 17:14:24 UTC (rev 278471)
@@ -1,3 +1,18 @@
+2021-06-04 Chris Dumez <[email protected]>
+
+ Avoid wasteful large allocation in SpeechRecognitionRemoteRealtimeMediaSource::setStorage()
+ https://bugs.webkit.org/show_bug.cgi?id=226644
+
+ Reviewed by Eric Carlson.
+
+ Avoid wasteful large allocation in SpeechRecognitionRemoteRealtimeMediaSource::setStorage().
+ setStorage() was setting m_buffer's size to the same size as the RingBuffer (2*sampleRate),
+ only to resize it to the size of the rendering quantum (512) later in
+ SpeechRecognitionRemoteRealtimeMediaSource::remoteAudioSamplesAvailable().
+
+ * UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:
+ (WebKit::SpeechRecognitionRemoteRealtimeMediaSource::setStorage):
+
2021-06-04 Alex Christensen <[email protected]>
Pass NetworkLoadParameters to NetworkDataTaskCocoa constructor
Modified: trunk/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp (278470 => 278471)
--- trunk/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp 2021-06-04 17:12:48 UTC (rev 278470)
+++ trunk/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp 2021-06-04 17:14:24 UTC (rev 278471)
@@ -80,7 +80,7 @@
m_description = description;
m_ringBuffer = WebCore::CARingBuffer::adoptStorage(makeUniqueRef<ReadOnlySharedRingBufferStorage>(handle), description, numberOfFrames).moveToUniquePtr();
- m_buffer = makeUnique<WebCore::WebAudioBufferList>(description, numberOfFrames);
+ m_buffer = makeUnique<WebCore::WebAudioBufferList>(description);
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
