Title: [278479] trunk/Source/WebCore
- Revision
- 278479
- Author
- [email protected]
- Date
- 2021-06-04 11:59:28 -0700 (Fri, 04 Jun 2021)
Log Message
Stop using legacy MainThreadTaskQueue in Document::didLogMessage()
https://bugs.webkit.org/show_bug.cgi?id=226645
Reviewed by Darin Adler.
Stop using legacy MainThreadTaskQueue in Document::didLogMessage() and use the HTML
event loop instead.
* dom/Document.cpp:
(WebCore::Document::didLogMessage):
* dom/Document.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (278478 => 278479)
--- trunk/Source/WebCore/ChangeLog 2021-06-04 18:52:23 UTC (rev 278478)
+++ trunk/Source/WebCore/ChangeLog 2021-06-04 18:59:28 UTC (rev 278479)
@@ -1,3 +1,17 @@
+2021-06-04 Chris Dumez <[email protected]>
+
+ Stop using legacy MainThreadTaskQueue in Document::didLogMessage()
+ https://bugs.webkit.org/show_bug.cgi?id=226645
+
+ Reviewed by Darin Adler.
+
+ Stop using legacy MainThreadTaskQueue in Document::didLogMessage() and use the HTML
+ event loop instead.
+
+ * dom/Document.cpp:
+ (WebCore::Document::didLogMessage):
+ * dom/Document.h:
+
2021-06-04 Antti Koivisto <[email protected]>
REGRESSION (maybe r276882): custom properties not available on host on initial paint
Modified: trunk/Source/WebCore/dom/Document.cpp (278478 => 278479)
--- trunk/Source/WebCore/dom/Document.cpp 2021-06-04 18:52:23 UTC (rev 278478)
+++ trunk/Source/WebCore/dom/Document.cpp 2021-06-04 18:59:28 UTC (rev 278479)
@@ -8514,11 +8514,10 @@
JSC::ConsoleClient::printConsoleMessage(message->source(), message->type(), message->level(), message->toString(), message->url(), message->line(), message->column());
}
- m_logMessageTaskQueue.enqueueTask([this, message = WTFMove(message)]() mutable {
- if (!this->page())
+ eventLoop().queueTask(TaskSource::InternalAsyncTask, [weakThis = makeWeakPtr(*this), message = WTFMove(message)]() mutable {
+ if (!weakThis || !weakThis->page())
return;
-
- addConsoleMessage(WTFMove(message));
+ weakThis->addConsoleMessage(WTFMove(message));
});
}
Modified: trunk/Source/WebCore/dom/Document.h (278478 => 278479)
--- trunk/Source/WebCore/dom/Document.h 2021-06-04 18:52:23 UTC (rev 278478)
+++ trunk/Source/WebCore/dom/Document.h 2021-06-04 18:59:28 UTC (rev 278479)
@@ -1954,8 +1954,6 @@
std::unique_ptr<DeviceOrientationAndMotionAccessController> m_deviceOrientationAndMotionAccessController;
#endif
- MainThreadTaskQueue m_logMessageTaskQueue;
-
Timer m_pendingTasksTimer;
Vector<Task> m_pendingTasks;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
