Title: [278511] trunk/Source/_javascript_Core
Revision
278511
Author
[email protected]
Date
2021-06-04 16:57:39 -0700 (Fri, 04 Jun 2021)

Log Message

Web Inspector: mark recently added protocol commands/events as page-only
https://bugs.webkit.org/show_bug.cgi?id=226661

Reviewed by Joseph Pecoraro.

* inspector/protocol/CSS.json:
* inspector/protocol/Network.json:
These commands are not implemented in ITML. By not specifying `"targetTypes": ["page"]` it's
implicitly saying that the command/event is supported by ITML since the command/event will
fall back to the domain's `"targetTypes"`, which includes ITML.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (278510 => 278511)


--- trunk/Source/_javascript_Core/ChangeLog	2021-06-04 23:44:21 UTC (rev 278510)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-06-04 23:57:39 UTC (rev 278511)
@@ -1,3 +1,16 @@
+2021-06-04  Devin Rousso  <[email protected]>
+
+        Web Inspector: mark recently added protocol commands/events as page-only
+        https://bugs.webkit.org/show_bug.cgi?id=226661
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/protocol/CSS.json:
+        * inspector/protocol/Network.json:
+        These commands are not implemented in ITML. By not specifying `"targetTypes": ["page"]` it's
+        implicitly saying that the command/event is supported by ITML since the command/event will
+        fall back to the domain's `"targetTypes"`, which includes ITML.
+
 2021-06-04  Yusuke Suzuki  <[email protected]>
 
         [JSC] Private static method should define privateClassBrandIdentifier in class-scope

Modified: trunk/Source/_javascript_Core/inspector/protocol/CSS.json (278510 => 278511)


--- trunk/Source/_javascript_Core/inspector/protocol/CSS.json	2021-06-04 23:44:21 UTC (rev 278510)
+++ trunk/Source/_javascript_Core/inspector/protocol/CSS.json	2021-06-04 23:57:39 UTC (rev 278511)
@@ -313,6 +313,7 @@
         {
             "name": "getFontDataForNode",
             "description": "Returns the primary font of the computed font cascade for a DOM node identified by <code>nodeId</code>.",
+            "targetTypes": ["page"],
             "parameters": [
                 { "name": "nodeId", "$ref": "DOM.NodeId" }
             ],
@@ -428,6 +429,7 @@
         {
             "name": "setLayoutContextTypeChangedMode",
             "description": "Change how layout context type changes are handled for nodes. When the new mode would observe nodes the frontend has not yet recieved, those nodes will be sent to the frontend immediately.",
+            "targetTypes": ["page"],
             "parameters": [
                 { "name": "mode", "$ref": "LayoutContextTypeChangedMode", "description": "The mode for how layout context type changes are handled." }
             ]
@@ -464,6 +466,7 @@
         {
             "name": "nodeLayoutContextTypeChanged",
             "description": "Called when a node's layout context type has changed.",
+            "targetTypes": ["page"],
             "parameters": [
                 { "name": "nodeId", "$ref": "DOM.NodeId", "description": "Identifier of the node whose layout context type changed." },
                 { "name": "layoutContextType", "$ref": "LayoutContextType", "optional": true, "description": "The new layout context type of the node. When not provided, the <code>LayoutContextType</code> of the node is not a context for which Web Inspector has specific functionality." }

Modified: trunk/Source/_javascript_Core/inspector/protocol/Network.json (278510 => 278511)


--- trunk/Source/_javascript_Core/inspector/protocol/Network.json	2021-06-04 23:44:21 UTC (rev 278510)
+++ trunk/Source/_javascript_Core/inspector/protocol/Network.json	2021-06-04 23:57:39 UTC (rev 278511)
@@ -279,6 +279,7 @@
         {
             "name": "interceptWithRequest",
             "description": "Replace intercepted request with the provided one.",
+            "targetTypes": ["page"],
             "parameters": [
                 { "name": "requestId", "$ref": "RequestId", "description": "Identifier for the intercepted Network request or response to continue." },
                 { "name": "url", "type": "string", "optional": true,"description": "HTTP request url." },
@@ -304,6 +305,7 @@
         {
             "name": "interceptRequestWithResponse",
             "description": "Provide response for an intercepted request. Request completely bypasses the network in this case and is immediately fulfilled with the provided data.",
+            "targetTypes": ["page"],
             "parameters": [
                 { "name": "requestId", "$ref": "RequestId", "description": "Identifier for the intercepted Network response to modify." },
                 { "name": "content", "type": "string" },
@@ -317,6 +319,7 @@
         {
             "name": "interceptRequestWithError",
             "description": "Fail request with given error type.",
+            "targetTypes": ["page"],
             "parameters": [
                 { "name": "requestId", "$ref": "RequestId", "description": "Identifier for the intercepted Network request to fail." },
                 { "name": "errorType", "$ref": "ResourceErrorType", "description": "Deliver error reason for the request failure." }
@@ -399,6 +402,7 @@
         {
             "name": "requestIntercepted",
             "description": "Fired when HTTP request has been intercepted. The frontend must respond with <code>Network.interceptContinue</code>, <code>Network.interceptWithRequest</code>` or <code>Network.interceptWithResponse</code>` to resolve this request.",
+            "targetTypes": ["page"],
             "parameters": [
                 { "name": "requestId", "$ref": "RequestId", "description": "Identifier for this intercepted network. Corresponds with an earlier <code>Network.requestWillBeSent</code>." },
                 { "name": "request", "$ref": "Request", "description": "Original request content that would proceed if this is continued." }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to