Title: [278513] trunk/Source/WebInspectorUI
- Revision
- 278513
- Author
- [email protected]
- Date
- 2021-06-04 17:22:08 -0700 (Fri, 04 Jun 2021)
Log Message
Web Inspector: cannot see experimental settings when inspecting `ServiceWorker`
https://bugs.webkit.org/show_bug.cgi?id=226666
Reviewed by Joseph Pecoraro.
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
There are experimental settings that have nothing to do with preview features or CSS. Don't
limit the Experimental pane to only if those things exist.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (278512 => 278513)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-06-05 00:16:56 UTC (rev 278512)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-06-05 00:22:08 UTC (rev 278513)
@@ -1,5 +1,17 @@
2021-06-04 Devin Rousso <[email protected]>
+ Web Inspector: cannot see experimental settings when inspecting `ServiceWorker`
+ https://bugs.webkit.org/show_bug.cgi?id=226666
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+ There are experimental settings that have nothing to do with preview features or CSS. Don't
+ limit the Experimental pane to only if those things exist.
+
+2021-06-04 Devin Rousso <[email protected]>
+
Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'InspectorBackend.Enum.Page.ResourceType')
https://bugs.webkit.org/show_bug.cgi?id=226664
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (278512 => 278513)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-06-05 00:16:56 UTC (rev 278512)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-06-05 00:22:08 UTC (rev 278513)
@@ -380,20 +380,17 @@
_createExperimentalSettingsView()
{
- let canShowPreviewFeatures = WI.canShowPreviewFeatures();
- let hasCSSDomain = InspectorBackend.hasDomain("CSS");
- if (!canShowPreviewFeatures && !hasCSSDomain)
- return;
-
let experimentalSettingsView = new WI.SettingsView("experimental", WI.UIString("Experimental"));
let initialValues = new Map;
+ let canShowPreviewFeatures = WI.canShowPreviewFeatures();
if (canShowPreviewFeatures) {
experimentalSettingsView.addSetting(WI.UIString("Staging:"), WI.settings.experimentalEnablePreviewFeatures, WI.UIString("Enable Preview Features"));
experimentalSettingsView.addSeparator();
}
+ let hasCSSDomain = InspectorBackend.hasDomain("CSS");
if (hasCSSDomain) {
let stylesGroup = experimentalSettingsView.addGroup(WI.UIString("Styles:"));
stylesGroup.addSetting(WI.settings.experimentalEnableStylesJumpToEffective, WI.UIString("Show jump to effective property button"));
@@ -428,7 +425,8 @@
}, reloadInspectorContainerElement);
}
- listenForChange(WI.settings.experimentalEnablePreviewFeatures);
+ if (canShowPreviewFeatures)
+ listenForChange(WI.settings.experimentalEnablePreviewFeatures);
if (hasCSSDomain) {
listenForChange(WI.settings.experimentalEnableStylesJumpToEffective);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
