Title: [278546] trunk/Source
- Revision
- 278546
- Author
- [email protected]
- Date
- 2021-06-06 23:31:54 -0700 (Sun, 06 Jun 2021)
Log Message
Unreviewed, reverting r277464.
https://bugs.webkit.org/show_bug.cgi?id=226709
No longer necessary
Reverted changeset:
"Work around WebCore failing to build due to NDEBUG getting
undefined in release"
https://bugs.webkit.org/show_bug.cgi?id=225782
https://trac.webkit.org/changeset/277464
Modified Paths
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (278545 => 278546)
--- trunk/Source/WebCore/PAL/ChangeLog 2021-06-07 06:19:03 UTC (rev 278545)
+++ trunk/Source/WebCore/PAL/ChangeLog 2021-06-07 06:31:54 UTC (rev 278546)
@@ -1,3 +1,17 @@
+2021-06-06 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r277464.
+ https://bugs.webkit.org/show_bug.cgi?id=226709
+
+ No longer necessary
+
+ Reverted changeset:
+
+ "Work around WebCore failing to build due to NDEBUG getting
+ undefined in release"
+ https://bugs.webkit.org/show_bug.cgi?id=225782
+ https://trac.webkit.org/changeset/277464
+
2021-06-05 Wenson Hsieh <[email protected]>
[macOS] Move DataDetectors softlinking in DataDetectorsSPI.h out into a separate PAL header
Modified: trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h (278545 => 278546)
--- trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h 2021-06-07 06:19:03 UTC (rev 278545)
+++ trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h 2021-06-07 06:31:54 UTC (rev 278546)
@@ -38,11 +38,6 @@
#if USE(APPLE_INTERNAL_SDK)
-// FIXME (77983361): Remove this workaround when <rdar://problem/77977216> is fixed.
-#if defined(NDEBUG) && NDEBUG
-#define WK_NDEBUG 1
-#endif
-
#include <CoreGraphics/CGContextDelegatePrivate.h>
#include <CoreGraphics/CGFontCache.h>
#include <CoreGraphics/CGPathPrivate.h>
@@ -49,11 +44,6 @@
#include <CoreGraphics/CoreGraphicsPrivate.h>
#include <CoreGraphics/CGStylePrivate.h>
-#if defined(WK_NDEBUG) && !defined(NDEBUG)
-#define NDEBUG 1
-#undef WK_NDEBUG
-#endif
-
#if PLATFORM(MAC)
#include <ColorSync/ColorSyncPriv.h>
#include <CoreGraphics/CGAccessibility.h>
Modified: trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h (278545 => 278546)
--- trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h 2021-06-07 06:19:03 UTC (rev 278545)
+++ trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h 2021-06-07 06:31:54 UTC (rev 278546)
@@ -31,20 +31,10 @@
#if USE(APPLE_INTERNAL_SDK)
-// FIXME (77983361): Remove this workaround when <rdar://problem/77977216> is fixed.
-#if defined(NDEBUG) && NDEBUG
-#define WK_NDEBUG 1
-#endif
-
#import <GraphicsServices/GraphicsServices.h>
-#if defined(WK_NDEBUG) && !defined(NDEBUG)
-#define NDEBUG 1
-#undef WK_NDEBUG
#endif
-#endif
-
WTF_EXTERN_C_BEGIN
void GSInitialize(void);
Modified: trunk/Source/WebKit/ChangeLog (278545 => 278546)
--- trunk/Source/WebKit/ChangeLog 2021-06-07 06:19:03 UTC (rev 278545)
+++ trunk/Source/WebKit/ChangeLog 2021-06-07 06:31:54 UTC (rev 278546)
@@ -1,3 +1,17 @@
+2021-06-06 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r277464.
+ https://bugs.webkit.org/show_bug.cgi?id=226709
+
+ No longer necessary
+
+ Reverted changeset:
+
+ "Work around WebCore failing to build due to NDEBUG getting
+ undefined in release"
+ https://bugs.webkit.org/show_bug.cgi?id=225782
+ https://trac.webkit.org/changeset/277464
+
2021-06-06 Wenson Hsieh <[email protected]>
Turn TextIteratorBehaviorFlag into an enum class and wrap it in OptionSet
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (278545 => 278546)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2021-06-07 06:19:03 UTC (rev 278545)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2021-06-07 06:31:54 UTC (rev 278546)
@@ -27,11 +27,6 @@
#if USE(APPLE_INTERNAL_SDK)
-// FIXME (77983361): Remove this workaround when <rdar://problem/77977216> is fixed.
-#if defined(NDEBUG) && NDEBUG
-#define WK_NDEBUG 1
-#endif
-
#import <UIKit/NSTextAlternatives.h>
#import <UIKit/UIAlertController_Private.h>
#import <UIKit/UIApplication_Private.h>
@@ -140,11 +135,6 @@
#import <UIKit/UIPointerStyle_Private.h>
#endif
-#if defined(WK_NDEBUG) && !defined(NDEBUG)
-#define NDEBUG 1
-#undef WK_NDEBUG
-#endif
-
#else // USE(APPLE_INTERNAL_SDK)
#if ENABLE(DRAG_SUPPORT)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
