Title: [278555] trunk/Source/WTF
Revision
278555
Author
[email protected]
Date
2021-06-07 04:40:51 -0700 (Mon, 07 Jun 2021)

Log Message

[GStreamer] Remove spurious assert in WTF::DataMutex
https://bugs.webkit.org/show_bug.cgi?id=226714

Reviewed by Michael Catanzaro.

Remove DATA_MUTEX_CHECK(!mutex().isHeld()); from the DataMutexLocker
constructor, introduced in r278248.

Trying to lock a currently held mutex is not an error condition that
should crash the process, it will just wait for its turn to lock it.

* wtf/DataMutex.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (278554 => 278555)


--- trunk/Source/WTF/ChangeLog	2021-06-07 11:40:05 UTC (rev 278554)
+++ trunk/Source/WTF/ChangeLog	2021-06-07 11:40:51 UTC (rev 278555)
@@ -1,3 +1,18 @@
+2021-06-07  Alicia Boya GarcĂ­a  <[email protected]>
+
+        [GStreamer] Remove spurious assert in WTF::DataMutex
+        https://bugs.webkit.org/show_bug.cgi?id=226714
+
+        Reviewed by Michael Catanzaro.
+
+        Remove DATA_MUTEX_CHECK(!mutex().isHeld()); from the DataMutexLocker
+        constructor, introduced in r278248.
+
+        Trying to lock a currently held mutex is not an error condition that
+        should crash the process, it will just wait for its turn to lock it.
+
+        * wtf/DataMutex.h:
+
 2021-06-06  Chris Dumez  <[email protected]>
 
         Stop using legacy EventLoopDeferrableTask

Modified: trunk/Source/WTF/wtf/DataMutex.h (278554 => 278555)


--- trunk/Source/WTF/wtf/DataMutex.h	2021-06-07 11:40:05 UTC (rev 278554)
+++ trunk/Source/WTF/wtf/DataMutex.h	2021-06-07 11:40:51 UTC (rev 278555)
@@ -65,7 +65,6 @@
     explicit DataMutexLocker(DataMutex<T>& dataMutex) WTF_ACQUIRES_LOCK(m_dataMutex.m_mutex)
         : m_dataMutex(dataMutex)
     {
-        DATA_MUTEX_CHECK(!mutex().isHeld());
         mutex().lock();
         m_isLocked = true;
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to