Title: [278586] trunk/Source/WebCore
Revision
278586
Author
[email protected]
Date
2021-06-07 18:28:30 -0700 (Mon, 07 Jun 2021)

Log Message

Fix localized strings after r278202
https://bugs.webkit.org/show_bug.cgi?id=226742

Reviewed by Eric Carlson.

* Scripts/extract-localizable-strings.pl:
Add support for `WEB_UI_CFSTRING_KEY`.

* en.lproj/Localizable.strings:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (278585 => 278586)


--- trunk/Source/WebCore/ChangeLog	2021-06-08 01:10:23 UTC (rev 278585)
+++ trunk/Source/WebCore/ChangeLog	2021-06-08 01:28:30 UTC (rev 278586)
@@ -1,3 +1,15 @@
+2021-06-07  Devin Rousso  <[email protected]>
+
+        Fix localized strings after r278202
+        https://bugs.webkit.org/show_bug.cgi?id=226742
+
+        Reviewed by Eric Carlson.
+
+        * Scripts/extract-localizable-strings.pl:
+        Add support for `WEB_UI_CFSTRING_KEY`.
+
+        * en.lproj/Localizable.strings:
+
 2021-06-07  Alexey Shvayka  <[email protected]>
 
         Window should behave like a legacy platform object without indexed setter

Modified: trunk/Source/WebCore/Scripts/extract-localizable-strings.pl (278585 => 278586)


--- trunk/Source/WebCore/Scripts/extract-localizable-strings.pl	2021-06-08 01:10:23 UTC (rev 278585)
+++ trunk/Source/WebCore/Scripts/extract-localizable-strings.pl	2021-06-08 01:28:30 UTC (rev 278586)
@@ -186,7 +186,7 @@
                         # FIXME: Validate UTF-8 here?
                         $UIString = $string;
                         $expected = ",";
-                    } elsif (($macro =~ /(WEB_)?UI_STRING_KEY(_INTERNAL)?$/) and !defined $key) {
+                    } elsif (($macro =~ /(WEB_)?UI_(CF)?STRING_KEY(_INTERNAL)?$/) and !defined $key) {
                         # FIXME: Validate UTF-8 here?
                         $key = $string;
                         $expected = ",";
@@ -245,7 +245,7 @@
                     emitError($file, $., "found $token but expected $expected");
                     $expected = "";
                 }
-                if (($token =~ /(WEB_)?UI_STRING(_KEY)?(_INTERNAL)?$/) || ($token =~ /WEB_UI_NSSTRING$/) || ($token =~ /WEB_UI_STRING_WITH_MNEMONIC$/) || ($token =~ /WEB_UI_CFSTRING$/)) {
+                if (($token =~ /(WEB_)?UI_(CF)?STRING(_KEY)?(_INTERNAL)?$/) || ($token =~ /WEB_UI_NSSTRING$/) || ($token =~ /WEB_UI_STRING_WITH_MNEMONIC$/)) {
                     $expected = "(";
                     $macro = $token;
                     $UIString = undef;

Modified: trunk/Source/WebCore/en.lproj/Localizable.strings (278585 => 278586)


--- trunk/Source/WebCore/en.lproj/Localizable.strings	2021-06-08 01:10:23 UTC (rev 278585)
+++ trunk/Source/WebCore/en.lproj/Localizable.strings	2021-06-08 01:28:30 UTC (rev 278586)
@@ -52,7 +52,7 @@
 /* visible name of the network process. The argument is the application name. */
 "%@ Networking" = "%@ Networking";
 
-/* SDH (i.e. deaf and/or hard of hearing) text track display name format that includes the language and/or locale (e.g. 'English SDH').  */
+/* SDH (i.e. deaf and/or hard of hearing) text track display name format that includes the language and/or locale (e.g. 'English SDH'). */
 "%@ SDH (text track)" = "%@ SDH";
 
 /* Visible name of Service Worker process. The argument is the application name. */
@@ -269,7 +269,7 @@
 "Click to restart" = "Click to restart";
 
 /* Display name for audio track kind 'commentary'. */
-"Commentary (audio track)" = "%@ Commentary";
+"Commentary (audio track)" = "Commentary";
 
 /* WKErrorContentRuleListStoreCompileFailed description */
 "Compiling a WKContentRuleList failed" = "Compiling a WKContentRuleList failed";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to