Modified: trunk/Source/WebKit/ChangeLog (278595 => 278596)
--- trunk/Source/WebKit/ChangeLog 2021-06-08 07:57:00 UTC (rev 278595)
+++ trunk/Source/WebKit/ChangeLog 2021-06-08 08:00:16 UTC (rev 278596)
@@ -1,5 +1,22 @@
2021-06-08 Carlos Garcia Campos <[email protected]>
+ [SOUP] Several timing tests failing since r278477
+ https://bugs.webkit.org/show_bug.cgi?id=226728
+
+ Reviewed by Michael Catanzaro.
+
+ responseBodyBytesReceived and responseBodyDecodedSize are expected to be always filled, and not only when
+ shouldCaptureExtraNetworkLoadMetrics() returns true.
+
+ Fixes: imported/w3c/web-platform-tests/navigation-timing/test_document_onload.html
+ imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
+ imported/w3c/web-platform-tests/resource-timing/cors-preflight.any.worker.html
+
+ * NetworkProcess/soup/NetworkDataTaskSoup.cpp:
+ (WebKit::NetworkDataTaskSoup::createRequest):
+
+2021-06-08 Carlos Garcia Campos <[email protected]>
+
REGRESSION(r278391): [SOUP] Test fast/dom/webtiming.html is failing
https://bugs.webkit.org/show_bug.cgi?id=226726
Modified: trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp (278595 => 278596)
--- trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp 2021-06-08 07:57:00 UTC (rev 278595)
+++ trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp 2021-06-08 08:00:16 UTC (rev 278596)
@@ -231,10 +231,10 @@
#else
g_signal_connect(m_soupMessage.get(), "authenticate", G_CALLBACK(authenticateCallback), this);
g_signal_connect(m_soupMessage.get(), "accept-certificate", G_CALLBACK(acceptCertificateCallback), this);
+ g_signal_connect(m_soupMessage.get(), "got-body", G_CALLBACK(gotBodyCallback), this);
if (shouldCaptureExtraNetworkLoadMetrics()) {
g_signal_connect(m_soupMessage.get(), "wrote-headers", G_CALLBACK(wroteHeadersCallback), this);
g_signal_connect(m_soupMessage.get(), "wrote-body", G_CALLBACK(wroteBodyCallback), this);
- g_signal_connect(m_soupMessage.get(), "got-body", G_CALLBACK(gotBodyCallback), this);
}
#endif
g_signal_connect(m_soupMessage.get(), "restarted", G_CALLBACK(restartedCallback), this);
@@ -1177,7 +1177,7 @@
void NetworkDataTaskSoup::gotBodyCallback(SoupMessage* soupMessage, NetworkDataTaskSoup* task)
{
- if (task->state() == State::Canceling || task->state() == State::Completed || !task->m_client) {
+ if (task->state() == State::Canceling || task->state() == State::Completed || (!task->m_client && !task->isDownload())) {
task->clearRequest();
return;
}
