Title: [278663] trunk/Source/WebKit
- Revision
- 278663
- Author
- [email protected]
- Date
- 2021-06-09 09:33:46 -0700 (Wed, 09 Jun 2021)
Log Message
[iOS] UIDelegate::UIClient::fullscreenMayReturnToInline() is not called when a video exits fullscreen
https://bugs.webkit.org/show_bug.cgi?id=226785
Reviewed by Eric Carlson.
On iOS, `UIDelegate::UIClient::fullscreenMayReturnToInline()` is called when
a video exits picture-in-picture, but not when a video exits fullscreen.
This patch fixes that.
We cannot add a regression test for this patch before fixing webkit.org/b/212654.
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::exitFullscreen):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (278662 => 278663)
--- trunk/Source/WebKit/ChangeLog 2021-06-09 16:31:25 UTC (rev 278662)
+++ trunk/Source/WebKit/ChangeLog 2021-06-09 16:33:46 UTC (rev 278663)
@@ -1,3 +1,19 @@
+2021-06-09 Peng Liu <[email protected]>
+
+ [iOS] UIDelegate::UIClient::fullscreenMayReturnToInline() is not called when a video exits fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=226785
+
+ Reviewed by Eric Carlson.
+
+ On iOS, `UIDelegate::UIClient::fullscreenMayReturnToInline()` is called when
+ a video exits picture-in-picture, but not when a video exits fullscreen.
+ This patch fixes that.
+
+ We cannot add a regression test for this patch before fixing webkit.org/b/212654.
+
+ * UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
+ (WebKit::VideoFullscreenManagerProxy::exitFullscreen):
+
2021-06-09 Diego Pino Garcia <[email protected]>
[GTK] Do not depend on resources provided by the GNOME icon theme
Modified: trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm (278662 => 278663)
--- trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm 2021-06-09 16:31:25 UTC (rev 278662)
+++ trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm 2021-06-09 16:33:46 UTC (rev 278663)
@@ -625,6 +625,9 @@
#if !PLATFORM(IOS_FAMILY)
IntRect finalWindowRect;
m_page->rootViewToWindow(enclosingIntRect(finalRect), finalWindowRect);
+#else
+ if (hasMode(WebCore::HTMLMediaElementEnums::VideoFullscreenModeStandard))
+ m_page->fullscreenMayReturnToInline();
#endif
if (m_mockVideoPresentationModeEnabled) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
