Title: [278681] trunk/Source/WebCore
Revision
278681
Author
[email protected]
Date
2021-06-09 16:41:30 -0700 (Wed, 09 Jun 2021)

Log Message

Nullptr crash in MediaSource::updateBufferedIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=226851
rdar://79059134

Reviewed by Devin Rousso.

No new tests, I was unable to come up with a reproducible case.

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::updateBufferedIfNeeded): NULL-check `m_private`.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (278680 => 278681)


--- trunk/Source/WebCore/ChangeLog	2021-06-09 22:46:43 UTC (rev 278680)
+++ trunk/Source/WebCore/ChangeLog	2021-06-09 23:41:30 UTC (rev 278681)
@@ -1,3 +1,16 @@
+2021-06-09  Eric Carlson  <[email protected]>
+
+        Nullptr crash in MediaSource::updateBufferedIfNeeded
+        https://bugs.webkit.org/show_bug.cgi?id=226851
+        rdar://79059134
+
+        Reviewed by Devin Rousso.
+
+        No new tests, I was unable to come up with a reproducible case.
+
+        * Modules/mediasource/MediaSource.cpp:
+        (WebCore::MediaSource::updateBufferedIfNeeded): NULL-check `m_private`.
+
 2021-06-09  Chris Dumez  <[email protected]>
 
         Avoid some calls to StringView::toString() / StringView::toStringWithoutCopying()

Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (278680 => 278681)


--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp	2021-06-09 22:46:43 UTC (rev 278680)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp	2021-06-09 23:41:30 UTC (rev 278681)
@@ -1155,7 +1155,8 @@
         m_buffered->intersectWith(sourceRanges);
     }
 
-    m_private->bufferedChanged(*m_buffered);
+    if (m_private)
+        m_private->bufferedChanged(*m_buffered);
 }
 
 #if !RELEASE_LOG_DISABLED
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to