Title: [278690] trunk/Source/WebCore
- Revision
- 278690
- Author
- [email protected]
- Date
- 2021-06-09 20:23:49 -0700 (Wed, 09 Jun 2021)
Log Message
Add window.internals.log()
https://bugs.webkit.org/show_bug.cgi?id=226403
Reviewed by Tim Horton.
window.internals.log() writes output to stderr using WTFLogAlways.
This may be useful for interleaving some output generated from within a
test with WebCore logging, which also goes to stderr. console.log()
doesn't work for this, since that goes to stdout and is captured as
the test output.
* testing/Internals.cpp:
(WebCore::Internals::log):
* testing/Internals.h:
* testing/Internals.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (278689 => 278690)
--- trunk/Source/WebCore/ChangeLog 2021-06-10 03:17:05 UTC (rev 278689)
+++ trunk/Source/WebCore/ChangeLog 2021-06-10 03:23:49 UTC (rev 278690)
@@ -1,3 +1,21 @@
+2021-06-09 Cameron McCormack <[email protected]>
+
+ Add window.internals.log()
+ https://bugs.webkit.org/show_bug.cgi?id=226403
+
+ Reviewed by Tim Horton.
+
+ window.internals.log() writes output to stderr using WTFLogAlways.
+ This may be useful for interleaving some output generated from within a
+ test with WebCore logging, which also goes to stderr. console.log()
+ doesn't work for this, since that goes to stdout and is captured as
+ the test output.
+
+ * testing/Internals.cpp:
+ (WebCore::Internals::log):
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
2021-06-09 Cathie Chen <[email protected]>
Aspect ratio from width and height attribute is not compatible to string with invalid ends
Modified: trunk/Source/WebCore/testing/Internals.cpp (278689 => 278690)
--- trunk/Source/WebCore/testing/Internals.cpp 2021-06-10 03:17:05 UTC (rev 278689)
+++ trunk/Source/WebCore/testing/Internals.cpp 2021-06-10 03:23:49 UTC (rev 278690)
@@ -767,6 +767,11 @@
return toString(value);
}
+void Internals::log(const String& value)
+{
+ WTFLogAlways("%s", value.utf8().data());
+}
+
bool Internals::isPreloaded(const String& url)
{
Document* document = contextDocument();
Modified: trunk/Source/WebCore/testing/Internals.h (278689 => 278690)
--- trunk/Source/WebCore/testing/Internals.h 2021-06-10 03:17:05 UTC (rev 278689)
+++ trunk/Source/WebCore/testing/Internals.h 2021-06-10 03:23:49 UTC (rev 278690)
@@ -169,6 +169,7 @@
bool nodeNeedsStyleRecalc(Node&);
String styleChangeType(Node&);
String description(JSC::JSValue);
+ void log(const String&);
bool isPreloaded(const String& url);
bool isLoadingFromMemoryCache(const String& url);
Modified: trunk/Source/WebCore/testing/Internals.idl (278689 => 278690)
--- trunk/Source/WebCore/testing/Internals.idl 2021-06-10 03:17:05 UTC (rev 278689)
+++ trunk/Source/WebCore/testing/Internals.idl 2021-06-10 03:23:49 UTC (rev 278690)
@@ -280,6 +280,7 @@
boolean nodeNeedsStyleRecalc(Node node);
DOMString styleChangeType(Node node);
DOMString description(any value);
+ undefined log(DOMString value);
// Animated image pausing testing.
boolean hasPausedImageAnimations(Element element);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
