Title: [106115] trunk/Source/WebCore
- Revision
- 106115
- Author
- [email protected]
- Date
- 2012-01-27 06:08:49 -0800 (Fri, 27 Jan 2012)
Log Message
Web Inspector: detailed heap snapshot: Replace (Native objects) root element
with '(Detached DOM trees)' and '(Document DOM trees)'
https://bugs.webkit.org/show_bug.cgi?id=77201
I think it'd be nice to replace one group containing all native objects with
separate groups for different types of native objects.
Reviewed by Yury Semikhatsky.
* bindings/v8/RetainedDOMInfo.cpp:
(WebCore::RetainedDOMInfo::GetGroupLabel):
(WebCore):
* bindings/v8/RetainedDOMInfo.h:
(RetainedDOMInfo):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (106114 => 106115)
--- trunk/Source/WebCore/ChangeLog 2012-01-27 14:02:15 UTC (rev 106114)
+++ trunk/Source/WebCore/ChangeLog 2012-01-27 14:08:49 UTC (rev 106115)
@@ -1,3 +1,20 @@
+2012-01-27 Ilya Tikhonovsky <[email protected]>
+
+ Web Inspector: detailed heap snapshot: Replace (Native objects) root element
+ with '(Detached DOM trees)' and '(Document DOM trees)'
+ https://bugs.webkit.org/show_bug.cgi?id=77201
+
+ I think it'd be nice to replace one group containing all native objects with
+ separate groups for different types of native objects.
+
+ Reviewed by Yury Semikhatsky.
+
+ * bindings/v8/RetainedDOMInfo.cpp:
+ (WebCore::RetainedDOMInfo::GetGroupLabel):
+ (WebCore):
+ * bindings/v8/RetainedDOMInfo.h:
+ (RetainedDOMInfo):
+
2012-01-27 Nikolas Zimmermann <[email protected]>
<feImage> doesn't work with local references when using primitiveUnits="objectBoundingBox"
Modified: trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.cpp (106114 => 106115)
--- trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.cpp 2012-01-27 14:02:15 UTC (rev 106114)
+++ trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.cpp 2012-01-27 14:08:49 UTC (rev 106115)
@@ -61,6 +61,11 @@
return reinterpret_cast<intptr_t>(m_root);
}
+const char* RetainedDOMInfo::GetGroupLabel()
+{
+ return m_root->inDocument() ? "(Document DOM trees)" : "(Detached DOM trees)";
+}
+
const char* RetainedDOMInfo::GetLabel()
{
return m_root->inDocument() ? "Document DOM tree" : "Detached DOM tree";
Modified: trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.h (106114 => 106115)
--- trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.h 2012-01-27 14:02:15 UTC (rev 106114)
+++ trunk/Source/WebCore/bindings/v8/RetainedDOMInfo.h 2012-01-27 14:08:49 UTC (rev 106115)
@@ -45,6 +45,7 @@
virtual void Dispose();
virtual bool IsEquivalent(v8::RetainedObjectInfo* other);
virtual intptr_t GetHash();
+ virtual const char* GetGroupLabel();
virtual const char* GetLabel();
virtual intptr_t GetElementCount();
virtual intptr_t GetEquivalenceClass();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
