Title: [278748] trunk/Source/WebKit
Revision
278748
Author
[email protected]
Date
2021-06-10 19:36:35 -0700 (Thu, 10 Jun 2021)

Log Message

[WinCairo] Can't open WebInspector UI since r277787
https://bugs.webkit.org/show_bug.cgi?id=226908

Reviewed by Don Olmstead.

r277787 (Bug 226001) changed the return type of
WebURLSchemeTask::request() from const WebCore::ResourceRequest&
to WebCore::ResourceRequest.

InspectorResourceURLSchemeHandler::platformStartTask shouldn't
hold the reference of the temporary object.

* UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:
(WebKit::InspectorResourceURLSchemeHandler::platformStartTask):
Changed the type of requestURL from auto& to auto to copy the URL.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (278747 => 278748)


--- trunk/Source/WebKit/ChangeLog	2021-06-11 01:22:52 UTC (rev 278747)
+++ trunk/Source/WebKit/ChangeLog	2021-06-11 02:36:35 UTC (rev 278748)
@@ -1,3 +1,21 @@
+2021-06-10  Fujii Hironori  <[email protected]>
+
+        [WinCairo] Can't open WebInspector UI since r277787
+        https://bugs.webkit.org/show_bug.cgi?id=226908
+
+        Reviewed by Don Olmstead.
+
+        r277787 (Bug 226001) changed the return type of
+        WebURLSchemeTask::request() from const WebCore::ResourceRequest&
+        to WebCore::ResourceRequest.
+
+        InspectorResourceURLSchemeHandler::platformStartTask shouldn't
+        hold the reference of the temporary object.
+
+        * UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:
+        (WebKit::InspectorResourceURLSchemeHandler::platformStartTask):
+        Changed the type of requestURL from auto& to auto to copy the URL.
+
 2021-06-10  Wenson Hsieh  <[email protected]>
 
         [Live Text] Add a mechanism to regenerate text in an image element when it changes dimensions

Modified: trunk/Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp (278747 => 278748)


--- trunk/Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp	2021-06-11 01:22:52 UTC (rev 278747)
+++ trunk/Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp	2021-06-11 02:36:35 UTC (rev 278748)
@@ -42,7 +42,7 @@
 void InspectorResourceURLSchemeHandler::platformStartTask(WebPageProxy&, WebURLSchemeTask& task)
 {
 #if USE(CF) && USE(CURL)
-    auto& requestURL = task.request().url();
+    auto requestURL = task.request().url();
     auto requestPath = requestURL.fileSystemPath();
     if (requestPath.startsWith("\\"))
         requestPath.remove(0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to