Title: [278958] trunk/Source/WebCore
Revision
278958
Author
peng.l...@apple.com
Date
2021-06-16 15:22:06 -0700 (Wed, 16 Jun 2021)

Log Message

Some http/tests/ are crashing with ASSERTION FAILED: isInRoutingArbitrationForToken(token) || m_setupArbitrationOngoing
https://bugs.webkit.org/show_bug.cgi?id=226896

Reviewed by Darin Adler.

A follow-up patch to fix an issue in r278922. Remove the call to `contains()`
before `remove()` on a `WeakHashSet`.

* platform/audio/mac/SharedRoutingArbitrator.mm:
(WebCore::SharedRoutingArbitrator::endRoutingArbitrationForToken):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (278957 => 278958)


--- trunk/Source/WebCore/ChangeLog	2021-06-16 22:18:38 UTC (rev 278957)
+++ trunk/Source/WebCore/ChangeLog	2021-06-16 22:22:06 UTC (rev 278958)
@@ -1,3 +1,16 @@
+2021-06-16  Peng Liu  <peng.l...@apple.com>
+
+        Some http/tests/ are crashing with ASSERTION FAILED: isInRoutingArbitrationForToken(token) || m_setupArbitrationOngoing
+        https://bugs.webkit.org/show_bug.cgi?id=226896
+
+        Reviewed by Darin Adler.
+
+        A follow-up patch to fix an issue in r278922. Remove the call to `contains()`
+        before `remove()` on a `WeakHashSet`.
+
+        * platform/audio/mac/SharedRoutingArbitrator.mm:
+        (WebCore::SharedRoutingArbitrator::endRoutingArbitrationForToken):
+
 2021-06-16  Chris Dumez  <cdu...@apple.com>
 
         FileReader.readAsArrayBuffer misses checking for the type of blob param

Modified: trunk/Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.mm (278957 => 278958)


--- trunk/Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.mm	2021-06-16 22:18:38 UTC (rev 278957)
+++ trunk/Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.mm	2021-06-16 22:22:06 UTC (rev 278958)
@@ -120,8 +120,7 @@
 
 void SharedRoutingArbitrator::endRoutingArbitrationForToken(const Token& token)
 {
-    if (m_tokens.contains(token))
-        m_tokens.remove(token);
+    m_tokens.remove(token);
 
     if (!m_tokens.computesEmpty())
         return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to