Title: [279026] trunk
- Revision
- 279026
- Author
- [email protected]
- Date
- 2021-06-17 17:26:11 -0700 (Thu, 17 Jun 2021)
Log Message
Add support for IDBCursor.request
https://bugs.webkit.org/show_bug.cgi?id=227152
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline some WPT tests now that they are passing.
* web-platform-tests/IndexedDB/idbcursor-request.any-expected.txt:
* web-platform-tests/IndexedDB/idbcursor-request.any.worker-expected.txt:
* web-platform-tests/IndexedDB/idlharness.any-expected.txt:
* web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt:
Source/WebCore:
Add support for IDBCursor.request:
- https://w3c.github.io/IndexedDB/#dom-idbcursor-request
Both Blink and Gecko already support this.
No new tests, rebaselined existing tests.
* Modules/indexeddb/IDBCursor.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279025 => 279026)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-06-18 00:00:29 UTC (rev 279025)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-06-18 00:26:11 UTC (rev 279026)
@@ -1,5 +1,19 @@
2021-06-17 Chris Dumez <[email protected]>
+ Add support for IDBCursor.request
+ https://bugs.webkit.org/show_bug.cgi?id=227152
+
+ Reviewed by Geoffrey Garen.
+
+ Rebaseline some WPT tests now that they are passing.
+
+ * web-platform-tests/IndexedDB/idbcursor-request.any-expected.txt:
+ * web-platform-tests/IndexedDB/idbcursor-request.any.worker-expected.txt:
+ * web-platform-tests/IndexedDB/idlharness.any-expected.txt:
+ * web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt:
+
+2021-06-17 Chris Dumez <[email protected]>
+
Resync DOM WPT tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=227144
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbcursor-request.any-expected.txt (279025 => 279026)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbcursor-request.any-expected.txt 2021-06-18 00:00:29 UTC (rev 279025)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbcursor-request.any-expected.txt 2021-06-18 00:26:11 UTC (rev 279026)
@@ -1,6 +1,6 @@
-FAIL cursor.request from IDBObjectStore.openCursor assert_equals: cursor.request expected (object) object "[object IDBRequest]" but got (undefined) undefined
-FAIL cursor.request from IDBObjectStore.openKeyCursor assert_equals: cursor.request expected (object) object "[object IDBRequest]" but got (undefined) undefined
-FAIL cursor.request from IDBIndex.openCursor assert_equals: cursor.request expected (object) object "[object IDBRequest]" but got (undefined) undefined
-FAIL cursor.request from IDBIndex.openKeyCursor assert_equals: cursor.request expected (object) object "[object IDBRequest]" but got (undefined) undefined
+PASS cursor.request from IDBObjectStore.openCursor
+PASS cursor.request from IDBObjectStore.openKeyCursor
+PASS cursor.request from IDBIndex.openCursor
+PASS cursor.request from IDBIndex.openKeyCursor
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbcursor-request.any.worker-expected.txt (279025 => 279026)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbcursor-request.any.worker-expected.txt 2021-06-18 00:00:29 UTC (rev 279025)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbcursor-request.any.worker-expected.txt 2021-06-18 00:26:11 UTC (rev 279026)
@@ -1,6 +1,6 @@
-FAIL cursor.request from IDBObjectStore.openCursor assert_equals: cursor.request expected (object) object "[object IDBRequest]" but got (undefined) undefined
-FAIL cursor.request from IDBObjectStore.openKeyCursor assert_equals: cursor.request expected (object) object "[object IDBRequest]" but got (undefined) undefined
-FAIL cursor.request from IDBIndex.openCursor assert_equals: cursor.request expected (object) object "[object IDBRequest]" but got (undefined) undefined
-FAIL cursor.request from IDBIndex.openKeyCursor assert_equals: cursor.request expected (object) object "[object IDBRequest]" but got (undefined) undefined
+PASS cursor.request from IDBObjectStore.openCursor
+PASS cursor.request from IDBObjectStore.openKeyCursor
+PASS cursor.request from IDBIndex.openCursor
+PASS cursor.request from IDBIndex.openKeyCursor
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idlharness.any-expected.txt (279025 => 279026)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idlharness.any-expected.txt 2021-06-18 00:00:29 UTC (rev 279025)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idlharness.any-expected.txt 2021-06-18 00:26:11 UTC (rev 279026)
@@ -164,7 +164,7 @@
PASS IDBCursor interface: attribute direction
PASS IDBCursor interface: attribute key
PASS IDBCursor interface: attribute primaryKey
-FAIL IDBCursor interface: attribute request assert_true: The prototype object must have a property "request" expected true got false
+PASS IDBCursor interface: attribute request
PASS IDBCursor interface: operation advance(unsigned long)
PASS IDBCursor interface: operation continue(optional any)
PASS IDBCursor interface: operation continuePrimaryKey(any, any)
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt (279025 => 279026)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt 2021-06-18 00:00:29 UTC (rev 279025)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt 2021-06-18 00:26:11 UTC (rev 279026)
@@ -164,7 +164,7 @@
PASS IDBCursor interface: attribute direction
PASS IDBCursor interface: attribute key
PASS IDBCursor interface: attribute primaryKey
-FAIL IDBCursor interface: attribute request assert_true: The prototype object must have a property "request" expected true got false
+PASS IDBCursor interface: attribute request
PASS IDBCursor interface: operation advance(unsigned long)
PASS IDBCursor interface: operation continue(optional any)
PASS IDBCursor interface: operation continuePrimaryKey(any, any)
Modified: trunk/Source/WebCore/ChangeLog (279025 => 279026)
--- trunk/Source/WebCore/ChangeLog 2021-06-18 00:00:29 UTC (rev 279025)
+++ trunk/Source/WebCore/ChangeLog 2021-06-18 00:26:11 UTC (rev 279026)
@@ -1,5 +1,21 @@
2021-06-17 Chris Dumez <[email protected]>
+ Add support for IDBCursor.request
+ https://bugs.webkit.org/show_bug.cgi?id=227152
+
+ Reviewed by Geoffrey Garen.
+
+ Add support for IDBCursor.request:
+ - https://w3c.github.io/IndexedDB/#dom-idbcursor-request
+
+ Both Blink and Gecko already support this.
+
+ No new tests, rebaselined existing tests.
+
+ * Modules/indexeddb/IDBCursor.idl:
+
+2021-06-17 Chris Dumez <[email protected]>
+
Enable some more release logging in for ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=227142
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBCursor.idl (279025 => 279026)
--- trunk/Source/WebCore/Modules/indexeddb/IDBCursor.idl 2021-06-18 00:00:29 UTC (rev 279025)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBCursor.idl 2021-06-18 00:26:11 UTC (rev 279026)
@@ -33,8 +33,7 @@
readonly attribute IDBCursorDirection direction;
[CustomGetter] readonly attribute any key;
[CustomGetter] readonly attribute any primaryKey;
- // FIXME: Implement 'request'
- // [SameObject] readonly attribute IDBRequest request;
+ [SameObject] readonly attribute IDBRequest request;
undefined advance([EnforceRange] unsigned long count);
[CallWith=GlobalObject, ImplementedAs=continueFunction] undefined continue(optional any key);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
