Title: [279039] trunk
- Revision
- 279039
- Author
- [email protected]
- Date
- 2021-06-18 09:21:07 -0700 (Fri, 18 Jun 2021)
Log Message
[MSE][GStreamer] Soundcloud serves MP4 audio with empty tfdt boxes
https://bugs.webkit.org/show_bug.cgi?id=191419
Patch by Philippe Normand <[email protected]> on 2021-06-18
Reviewed by Michael Catanzaro.
Source/WebCore:
When MSE is used the player receives broken audio fragments, perhaps because the server
expects the client to repair them. Not much we can do about this on GStreamer side though,
so behave as a Chrome UserAgent and then MSE is not used, the player receives an MP3 stream.
* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):
Tools:
* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST): Add a test for the soundcloud quirk.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (279038 => 279039)
--- trunk/Source/WebCore/ChangeLog 2021-06-18 16:13:39 UTC (rev 279038)
+++ trunk/Source/WebCore/ChangeLog 2021-06-18 16:21:07 UTC (rev 279039)
@@ -1,3 +1,17 @@
+2021-06-18 Philippe Normand <[email protected]>
+
+ [MSE][GStreamer] Soundcloud serves MP4 audio with empty tfdt boxes
+ https://bugs.webkit.org/show_bug.cgi?id=191419
+
+ Reviewed by Michael Catanzaro.
+
+ When MSE is used the player receives broken audio fragments, perhaps because the server
+ expects the client to repair them. Not much we can do about this on GStreamer side though,
+ so behave as a Chrome UserAgent and then MSE is not used, the player receives an MP3 stream.
+
+ * platform/UserAgentQuirks.cpp:
+ (WebCore::urlRequiresChromeBrowser):
+
2021-06-18 Carlos Alberto Lopez Perez <[email protected]>
[LFC][WPE] Build failure with GCC 8.x
Modified: trunk/Source/WebCore/platform/UserAgentQuirks.cpp (279038 => 279039)
--- trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2021-06-18 16:13:39 UTC (rev 279038)
+++ trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2021-06-18 16:21:07 UTC (rev 279039)
@@ -62,6 +62,10 @@
if (domain == "docs.google.com")
return true;
+ // soundcloud.com serves broken MSE audio fragments with WebKitGTK's standard user agent.
+ if (baseDomain == "soundcloud.com")
+ return true;
+
return false;
}
Modified: trunk/Tools/ChangeLog (279038 => 279039)
--- trunk/Tools/ChangeLog 2021-06-18 16:13:39 UTC (rev 279038)
+++ trunk/Tools/ChangeLog 2021-06-18 16:21:07 UTC (rev 279039)
@@ -1,3 +1,13 @@
+2021-06-18 Philippe Normand <[email protected]>
+
+ [MSE][GStreamer] Soundcloud serves MP4 audio with empty tfdt boxes
+ https://bugs.webkit.org/show_bug.cgi?id=191419
+
+ Reviewed by Michael Catanzaro.
+
+ * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+ (TestWebKitAPI::TEST): Add a test for the soundcloud quirk.
+
2021-06-17 Mark Lam <[email protected]>
Define MacroAssemblerARM64E::numberOfPACBits based on OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH).
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (279038 => 279039)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp 2021-06-18 16:13:39 UTC (rev 279038)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp 2021-06-18 16:21:07 UTC (rev 279039)
@@ -86,6 +86,7 @@
assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
assertUserAgentForURLHasChromeBrowserQuirk("http://auth.mayohr.com/");
assertUserAgentForURLHasChromeBrowserQuirk("http://bankofamerica.com/");
+ assertUserAgentForURLHasChromeBrowserQuirk("http://soundcloud.com/");
assertUserAgentForURLHasFirefoxBrowserQuirk("http://bugzilla.redhat.com/");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
