Title: [279065] trunk/Source/ThirdParty/libwebrtc
- Revision
- 279065
- Author
- [email protected]
- Date
- 2021-06-21 03:13:28 -0700 (Mon, 21 Jun 2021)
Log Message
[GLIB] REGRESSION(r278701): numerous WebRTC tests failing after libwebrtc update to M92
https://bugs.webkit.org/show_bug.cgi?id=227172
Patch by Philippe Normand <[email protected]> on 2021-06-21
Reviewed by Adrian Perez de Castro.
Non-apple ports do not use the bundled libvpx library, they rely on the host libvpx instead.
LibWebRTC expects to depend on the bundled version, thus using its API. So we need to be
very careful with which libvpx version is used from the host, in order to avoid API/ABI
issues. Hence the version check should specify a version that is API/ABI compatible with
what libwebrtc expects.
This patch also re-enables data channel support, which was disabled during the update to M92
in CMake ports.
* CMakeLists.txt:
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt (279064 => 279065)
--- trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2021-06-21 08:36:09 UTC (rev 279064)
+++ trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2021-06-21 10:13:28 UTC (rev 279065)
@@ -4,7 +4,7 @@
file(MAKE_DIRECTORY ${libwebrtc_DERIVED_SOURCES_DIR})
if (NOT APPLE)
- find_package(LibVpx 1.7.0)
+ find_package(LibVpx 1.10.0)
if (NOT LIBVPX_FOUND)
message(FATAL_ERROR "libvpx is needed for USE_LIBWEBRTC.")
endif ()
@@ -1674,6 +1674,8 @@
WEBRTC_CODEC_ISAC
WEBRTC_CODEC_OPUS
WEBRTC_CODEC_RED
+ WEBRTC_HAVE_SCTP
+ WEBRTC_HAVE_USRSCTP
WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE
WEBRTC_INTELLIGIBILITY_ENHANCER=0
WEBRTC_NS_FLOAT
@@ -1731,7 +1733,6 @@
Source/third_party/libsrtp/crypto/include
Source/third_party/libsrtp/include
Source/third_party/libyuv/include
- Source/third_party/libvpx/source/libvpx
Source/third_party/opus/src/celt
Source/third_party/opus/src/include
Source/third_party/opus/src/silk
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (279064 => 279065)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-06-21 08:36:09 UTC (rev 279064)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-06-21 10:13:28 UTC (rev 279065)
@@ -1,3 +1,21 @@
+2021-06-21 Philippe Normand <[email protected]>
+
+ [GLIB] REGRESSION(r278701): numerous WebRTC tests failing after libwebrtc update to M92
+ https://bugs.webkit.org/show_bug.cgi?id=227172
+
+ Reviewed by Adrian Perez de Castro.
+
+ Non-apple ports do not use the bundled libvpx library, they rely on the host libvpx instead.
+ LibWebRTC expects to depend on the bundled version, thus using its API. So we need to be
+ very careful with which libvpx version is used from the host, in order to avoid API/ABI
+ issues. Hence the version check should specify a version that is API/ABI compatible with
+ what libwebrtc expects.
+
+ This patch also re-enables data channel support, which was disabled during the update to M92
+ in CMake ports.
+
+ * CMakeLists.txt:
+
2021-06-17 Commit Queue <[email protected]>
Unreviewed, reverting r279011.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
