Title: [279095] trunk/Tools
Revision
279095
Author
[email protected]
Date
2021-06-21 17:45:11 -0700 (Mon, 21 Jun 2021)

Log Message

[WK2] Don't process-swap on navigations within the same non-HTTP(s) protocol
https://bugs.webkit.org/show_bug.cgi?id=227220
<rdar://79106461>

Unreviewed follow-up to fix GTK test that started failing after the behavior
change in r279079.


* TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
(testWebExtensionPageID):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (279094 => 279095)


--- trunk/Tools/ChangeLog	2021-06-22 00:40:48 UTC (rev 279094)
+++ trunk/Tools/ChangeLog	2021-06-22 00:45:11 UTC (rev 279095)
@@ -1,3 +1,15 @@
+2021-06-21  Chris Dumez  <[email protected]>
+
+        [WK2] Don't process-swap on navigations within the same non-HTTP(s) protocol
+        https://bugs.webkit.org/show_bug.cgi?id=227220
+        <rdar://79106461>
+
+        Unreviewed follow-up to fix GTK test that started failing after the behavior
+        change in r279079.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
+        (testWebExtensionPageID):
+
 2021-06-21  Jonathan Bedard  <[email protected]>
 
         [results.webkit.org] XSS vulnerability in test name

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp (279094 => 279095)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp	2021-06-22 00:40:48 UTC (rev 279094)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp	2021-06-22 00:45:11 UTC (rev 279095)
@@ -492,9 +492,9 @@
 
     test->loadURI("foo://host6/");
     test->waitUntilLoadFinished();
-    g_assert_true(pageIDChangedEmitted);
+    g_assert_false(pageIDChangedEmitted);
     pageIDChangedEmitted = false;
-    g_assert_cmpuint(pageID, <, webkit_web_view_get_page_id(test->m_webView));
+    g_assert_cmpuint(pageID, ==, webkit_web_view_get_page_id(test->m_webView));
     pageID = webkit_web_view_get_page_id(test->m_webView);
     proxy = test->extensionProxy();
     checkTitle(test, proxy.get(), "Title6");
@@ -501,9 +501,9 @@
 
     test->goBack();
     test->waitUntilLoadFinished();
-    g_assert_true(pageIDChangedEmitted);
+    g_assert_false(pageIDChangedEmitted);
     pageIDChangedEmitted = false;
-    g_assert_cmpuint(pageID, >, webkit_web_view_get_page_id(test->m_webView));
+    g_assert_cmpuint(pageID, ==, webkit_web_view_get_page_id(test->m_webView));
     pageID = webkit_web_view_get_page_id(test->m_webView);
     proxy = test->extensionProxy();
     checkTitle(test, proxy.get(), "Title5");
@@ -510,9 +510,9 @@
 
     test->goForward();
     test->waitUntilLoadFinished();
-    g_assert_true(pageIDChangedEmitted);
+    g_assert_false(pageIDChangedEmitted);
     pageIDChangedEmitted = false;
-    g_assert_cmpuint(pageID, <, webkit_web_view_get_page_id(test->m_webView));
+    g_assert_cmpuint(pageID, ==, webkit_web_view_get_page_id(test->m_webView));
     pageID = webkit_web_view_get_page_id(test->m_webView);
     proxy = test->extensionProxy();
     checkTitle(test, proxy.get(), "Title6");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to