Title: [279166] trunk/Source/WebKit
- Revision
- 279166
- Author
- [email protected]
- Date
- 2021-06-22 23:34:31 -0700 (Tue, 22 Jun 2021)
Log Message
Message dropped when restoring webpages.
https://bugs.webkit.org/show_bug.cgi?id=227278
Reviewed by Tim Horton.
The message to initialize the state of highlightVisibility is dropped sometimes, but
fortunately, there is no need to pass the current state when initializing the
HighlightObserver, as WebPageProxy::creationParameters will obtain the correct
highlight state on initialization after r279078.
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::setUpHighlightsObserver):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (279165 => 279166)
--- trunk/Source/WebKit/ChangeLog 2021-06-23 01:33:57 UTC (rev 279165)
+++ trunk/Source/WebKit/ChangeLog 2021-06-23 06:34:31 UTC (rev 279166)
@@ -1,3 +1,18 @@
+2021-06-22 Megan Gardner <[email protected]>
+
+ Message dropped when restoring webpages.
+ https://bugs.webkit.org/show_bug.cgi?id=227278
+
+ Reviewed by Tim Horton.
+
+ The message to initialize the state of highlightVisibility is dropped sometimes, but
+ fortunately, there is no need to pass the current state when initializing the
+ HighlightObserver, as WebPageProxy::creationParameters will obtain the correct
+ highlight state on initialization after r279078.
+
+ * UIProcess/Cocoa/WebPageProxyCocoa.mm:
+ (WebKit::WebPageProxy::setUpHighlightsObserver):
+
2021-06-22 Wenson Hsieh <[email protected]>
[Live Text] [macOS] Add an internal option to disable inline text selection in images
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm (279165 => 279166)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm 2021-06-23 01:33:57 UTC (rev 279165)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm 2021-06-23 06:34:31 UTC (rev 279166)
@@ -614,7 +614,6 @@
setAppHighlightsVisibility(isVisible ? WebCore::HighlightVisibility::Visible : WebCore::HighlightVisibility::Hidden);
};
m_appHighlightsObserver = adoptNS([allocSYNotesActivationObserverInstance() initWithHandler:updateAppHighlightsVisibility]);
- updateAppHighlightsVisibility([m_appHighlightsObserver isVisible]);
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
