Title: [279277] trunk/Source/WebCore
- Revision
- 279277
- Author
- [email protected]
- Date
- 2021-06-25 06:49:07 -0700 (Fri, 25 Jun 2021)
Log Message
[GStreamer] Minor debugging improvements in mediastream source element
https://bugs.webkit.org/show_bug.cgi?id=227396
Patch by Philippe Normand <[email protected]> on 2021-06-25
Reviewed by Xabier Rodriguez-Calvar.
* platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Give representative name to
the appsrc elements embedded in the MediaStreamSource element. Also add logging calls
related with tracks observation.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (279276 => 279277)
--- trunk/Source/WebCore/ChangeLog 2021-06-25 12:37:49 UTC (rev 279276)
+++ trunk/Source/WebCore/ChangeLog 2021-06-25 13:49:07 UTC (rev 279277)
@@ -1,3 +1,14 @@
+2021-06-25 Philippe Normand <[email protected]>
+
+ [GStreamer] Minor debugging improvements in mediastream source element
+ https://bugs.webkit.org/show_bug.cgi?id=227396
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Give representative name to
+ the appsrc elements embedded in the MediaStreamSource element. Also add logging calls
+ related with tracks observation.
+
2021-06-25 Sergio Villar Senin <[email protected]>
[css-flexbox] Cleanup OverridingSizesScope RAII class
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp (279276 => 279277)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp 2021-06-25 12:37:49 UTC (rev 279276)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp 2021-06-25 13:49:07 UTC (rev 279277)
@@ -127,13 +127,18 @@
, m_track(track)
, m_padName(padName)
{
- if (track.type() == RealtimeMediaSource::Type::Audio)
+ const char* elementName = nullptr;
+ if (track.type() == RealtimeMediaSource::Type::Audio) {
m_audioTrack = AudioTrackPrivateMediaStream::create(track);
- else if (track.type() == RealtimeMediaSource::Type::Video)
+ elementName = "audiosrc";
+ } else if (track.type() == RealtimeMediaSource::Type::Video) {
m_videoTrack = VideoTrackPrivateMediaStream::create(track);
+ elementName = "videosrc";
+ } else
+ ASSERT_NOT_REACHED();
bool isCaptureTrack = track.isCaptureTrack();
- m_src = makeGStreamerElement("appsrc", nullptr);
+ m_src = makeGStreamerElement("appsrc", elementName);
g_object_set(m_src.get(), "is-live", TRUE, "format", GST_FORMAT_TIME, "emit-signals", TRUE, "min-percent", 100,
"do-timestamp", isCaptureTrack, nullptr);
@@ -162,6 +167,7 @@
if (m_isObserving)
return;
+ GST_DEBUG_OBJECT(m_src.get(), "Starting track/source observation");
m_track.addObserver(*this);
switch (m_track.type()) {
case RealtimeMediaSource::Type::Audio:
@@ -181,6 +187,7 @@
if (!m_isObserving)
return;
+ GST_DEBUG_OBJECT(m_src.get(), "Stopping track/source observation");
m_isObserving = false;
switch (m_track.type()) {
case RealtimeMediaSource::Type::Audio:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
