Title: [279294] trunk/Source/WebInspectorUI
Revision
279294
Author
[email protected]
Date
2021-06-25 11:50:15 -0700 (Fri, 25 Jun 2021)

Log Message

Web Inspector: Sources: Scope Chain sidebar panel is stripping repeating whitespace from strings
https://bugs.webkit.org/show_bug.cgi?id=227234

Reviewed by Devin Rousso.

String and Regular _expression_ values in Object Trees were having `white-space: nowrap;` applied to them, which
was redundant because `white-space: pre;` was already defined for `.formatted-string` and `.formatted-regexp`,
which makes sure that the text does not wrap unless it contains a newline, and these previews have newlines
replaced with a Unicode symbol to visually represent a newline without breaking to a new line.

* UserInterface/Views/ObjectTreeView.css:
(.object-tree-property :matches(.formatted-string, .formatted-regexp)): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (279293 => 279294)


--- trunk/Source/WebInspectorUI/ChangeLog	2021-06-25 18:46:59 UTC (rev 279293)
+++ trunk/Source/WebInspectorUI/ChangeLog	2021-06-25 18:50:15 UTC (rev 279294)
@@ -1,3 +1,18 @@
+2021-06-25  Patrick Angle  <[email protected]>
+
+        Web Inspector: Sources: Scope Chain sidebar panel is stripping repeating whitespace from strings
+        https://bugs.webkit.org/show_bug.cgi?id=227234
+
+        Reviewed by Devin Rousso.
+
+        String and Regular _expression_ values in Object Trees were having `white-space: nowrap;` applied to them, which
+        was redundant because `white-space: pre;` was already defined for `.formatted-string` and `.formatted-regexp`,
+        which makes sure that the text does not wrap unless it contains a newline, and these previews have newlines
+        replaced with a Unicode symbol to visually represent a newline without breaking to a new line.
+
+        * UserInterface/Views/ObjectTreeView.css:
+        (.object-tree-property :matches(.formatted-string, .formatted-regexp)): Deleted.
+
 2021-06-14  Patrick Angle  <[email protected]>
 
         [REGRESSION: r276616] Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._setupCodeMirror.getValue')

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css (279293 => 279294)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css	2021-06-25 18:46:59 UTC (rev 279293)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css	2021-06-25 18:50:15 UTC (rev 279294)
@@ -139,7 +139,3 @@
     margin-inline-start: 2px;
     vertical-align: -4px;
 }
-
-.object-tree-property :matches(.formatted-string, .formatted-regexp) {
-    white-space: nowrap;
-}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to