Title: [279338] trunk/Tools
- Revision
- 279338
- Author
- [email protected]
- Date
- 2021-06-28 06:57:15 -0700 (Mon, 28 Jun 2021)
Log Message
[webkitpy] Test timeouts not properly detected when running layout tests with Python 3
https://bugs.webkit.org/show_bug.cgi?id=227442
Patch by Philippe Normand <[email protected]> on 2021-06-28
Reviewed by Jonathan Bedard.
* Scripts/webkitpy/port/driver.py:
(Driver._check_for_driver_timeout): out_line contains a byte string, so test it as such.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (279337 => 279338)
--- trunk/Tools/ChangeLog 2021-06-28 12:41:01 UTC (rev 279337)
+++ trunk/Tools/ChangeLog 2021-06-28 13:57:15 UTC (rev 279338)
@@ -1,3 +1,13 @@
+2021-06-28 Philippe Normand <[email protected]>
+
+ [webkitpy] Test timeouts not properly detected when running layout tests with Python 3
+ https://bugs.webkit.org/show_bug.cgi?id=227442
+
+ Reviewed by Jonathan Bedard.
+
+ * Scripts/webkitpy/port/driver.py:
+ (Driver._check_for_driver_timeout): out_line contains a byte string, so test it as such.
+
2021-06-28 Carlos Garcia Campos <[email protected]>
[GTK] MiniBrowser: add an option to enable the web process sandbox
Modified: trunk/Tools/Scripts/webkitpy/port/driver.py (279337 => 279338)
--- trunk/Tools/Scripts/webkitpy/port/driver.py 2021-06-28 12:41:01 UTC (rev 279337)
+++ trunk/Tools/Scripts/webkitpy/port/driver.py 2021-06-28 13:57:15 UTC (rev 279338)
@@ -560,7 +560,7 @@
_log.debug(err_line)
if self._port.get_option("sample_on_timeout"):
self._port.sample_process(child_process_name, child_process_pid, self._target_host)
- if out_line == "FAIL: Timed out waiting for notifyDone to be called\n":
+ if out_line == b"FAIL: Timed out waiting for notifyDone to be called\n":
self._driver_timed_out = True
def _check_for_address_sanitizer_violation(self, error_line):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
