Title: [279352] trunk/Source/WebKit
- Revision
- 279352
- Author
- [email protected]
- Date
- 2021-06-28 16:56:54 -0700 (Mon, 28 Jun 2021)
Log Message
REGRESSION (r279305) [Mac DEBUG] 4 SOAuthorizationRedirect Tests are Crashing with Assert: !m_sheetWindow
https://bugs.webkit.org/show_bug.cgi?id=227454
<rdar://problem/79871423>
Reviewed by Kate Cheney.
The new assertion is wrong in the case that the app is hidden. When minimized (or hidden) we need to remember
to dismiss the sheet once Cocoa restores the app to visible state. So the m_sheetWindow may still exist after
returning from 'dismissViewController'. We should assert that either m_sheetWindow is nullptr, or that both
m_sheetWindow and m_sheetWindowWillCloseObserver exist.
* UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
(WebKit::SOAuthorizationSession::becomeCompleted):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (279351 => 279352)
--- trunk/Source/WebKit/ChangeLog 2021-06-28 23:52:26 UTC (rev 279351)
+++ trunk/Source/WebKit/ChangeLog 2021-06-28 23:56:54 UTC (rev 279352)
@@ -1,3 +1,19 @@
+2021-06-28 Brent Fulgham <[email protected]>
+
+ REGRESSION (r279305) [Mac DEBUG] 4 SOAuthorizationRedirect Tests are Crashing with Assert: !m_sheetWindow
+ https://bugs.webkit.org/show_bug.cgi?id=227454
+ <rdar://problem/79871423>
+
+ Reviewed by Kate Cheney.
+
+ The new assertion is wrong in the case that the app is hidden. When minimized (or hidden) we need to remember
+ to dismiss the sheet once Cocoa restores the app to visible state. So the m_sheetWindow may still exist after
+ returning from 'dismissViewController'. We should assert that either m_sheetWindow is nullptr, or that both
+ m_sheetWindow and m_sheetWindowWillCloseObserver exist.
+
+ * UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
+ (WebKit::SOAuthorizationSession::becomeCompleted):
+
2021-06-28 Kate Cheney <[email protected]>
I-beam pointer is vertical for vertical text
Modified: trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm (279351 => 279352)
--- trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm 2021-06-28 23:52:26 UTC (rev 279351)
+++ trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm 2021-06-28 23:56:54 UTC (rev 279352)
@@ -150,7 +150,7 @@
m_state = State::Completed;
dismissViewController();
#if PLATFORM(MAC)
- ASSERT(!m_sheetWindow);
+ ASSERT(!m_sheetWindow || (m_sheetWindow && m_sheetWindowWillCloseObserver));
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
