Title: [279582] trunk
Revision
279582
Author
[email protected]
Date
2021-07-06 08:17:41 -0700 (Tue, 06 Jul 2021)

Log Message

Remove MediaStreamTrack.onconstrainederror
https://bugs.webkit.org/show_bug.cgi?id=227696

Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated tests.

* Modules/mediastream/MediaStreamTrack.idl:
* dom/EventNames.h:
Remove never used/deprecated event handler.

LayoutTests:

* fast/mediastream/MediaStreamTrack-clone-expected.txt:
* fast/mediastream/MediaStreamTrack-clone.html:
* fast/mediastream/MediaStreamTrack.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (279581 => 279582)


--- trunk/LayoutTests/ChangeLog	2021-07-06 14:54:03 UTC (rev 279581)
+++ trunk/LayoutTests/ChangeLog	2021-07-06 15:17:41 UTC (rev 279582)
@@ -1,3 +1,14 @@
+2021-07-06  Youenn Fablet  <[email protected]>
+
+        Remove MediaStreamTrack.onconstrainederror
+        https://bugs.webkit.org/show_bug.cgi?id=227696
+
+        Reviewed by Eric Carlson.
+
+        * fast/mediastream/MediaStreamTrack-clone-expected.txt:
+        * fast/mediastream/MediaStreamTrack-clone.html:
+        * fast/mediastream/MediaStreamTrack.html:
+
 2021-07-05  Wenson Hsieh  <[email protected]>
 
         Live Text should not be visible in video thumbnail images behind "Skip Ad" button on YouTube

Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrack-clone-expected.txt (279581 => 279582)


--- trunk/LayoutTests/fast/mediastream/MediaStreamTrack-clone-expected.txt	2021-07-06 14:54:03 UTC (rev 279581)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrack-clone-expected.txt	2021-07-06 15:17:41 UTC (rev 279582)
@@ -7,6 +7,9 @@
 
 videoTrack = mediaStream.getVideoTracks()[0]
 Initialize event handler attributes on videoTrack
+PASS videoTrack.onoverconstrained is undefined
+PASS videoTrack.onoverconstrained is undefined
+PASS MediaStreamTrack.prototype.onoverconstrained is undefined
 
 videoTrack2 = videoTrack.clone()
 PASS videoTrack.id is not videoTrack2.id
@@ -18,7 +21,6 @@
 PASS videoTrack.onmute is not videoTrack2.onmute
 PASS videoTrack.onunmute is not videoTrack2.onunmute
 PASS videoTrack.onended is not videoTrack2.onended
-PASS videoTrack.onoverconstrained is not videoTrack2.onoverconstrained
 PASS videoTrack.readyState is not videoTrack2.readyState
 PASS videoTrack.readyState is videoTrack3.readyState
 PASS successfullyParsed is true

Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrack-clone.html (279581 => 279582)


--- trunk/LayoutTests/fast/mediastream/MediaStreamTrack-clone.html	2021-07-06 14:54:03 UTC (rev 279581)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrack-clone.html	2021-07-06 15:17:41 UTC (rev 279582)
@@ -21,7 +21,9 @@
                 videoTrack._onmute_ = function () {};
                 videoTrack._onunmute_ = function () {};
                 videoTrack._onended_ = function () {};
-                videoTrack._onoverconstrained_ = function () {};
+                shouldBe('videoTrack.onoverconstrained', 'undefined');
+                shouldBe('videoTrack.onoverconstrained', 'undefined');
+                shouldBe('MediaStreamTrack.prototype.onoverconstrained', 'undefined');
 
                 debug("");
                 evalAndLog("videoTrack2 = videoTrack.clone()");
@@ -36,7 +38,6 @@
                 shouldNotBe('videoTrack.onmute', 'videoTrack2.onmute');
                 shouldNotBe('videoTrack.onunmute', 'videoTrack2.onunmute');
                 shouldNotBe('videoTrack.onended', 'videoTrack2.onended');
-                shouldNotBe('videoTrack.onoverconstrained', 'videoTrack2.onoverconstrained');
 
                 videoTrack.stop();
                 shouldNotBe('videoTrack.readyState', 'videoTrack2.readyState');

Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html (279581 => 279582)


--- trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html	2021-07-06 14:54:03 UTC (rev 279581)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html	2021-07-06 15:17:41 UTC (rev 279582)
@@ -40,12 +40,6 @@
                 shouldBeEqualToString('videoTrack.readyState', 'live');
             }
 
-            function onTrackOverConstrained()
-            {
-                testPassed('Track onoverconstrained callback succeeded.');
-                finishJSTest();
-            }
-
             function onTrackUnmute()
             {
                 testPassed('Track onunmute callback succeeded.');
@@ -142,7 +136,6 @@
                 videoTrack._onunmute_ = onTrackUnmute;
                 videoTrack._onended_ = onTrackEnded;
                 videoTrack._onstarted_ = onTrackStarted;
-                videoTrack._onoverconstrained_ = onTrackOverConstrained;
             
                 debug("");
                 evalAndLog("videoTrack2 = videoTrack.clone()");

Modified: trunk/Source/WebCore/ChangeLog (279581 => 279582)


--- trunk/Source/WebCore/ChangeLog	2021-07-06 14:54:03 UTC (rev 279581)
+++ trunk/Source/WebCore/ChangeLog	2021-07-06 15:17:41 UTC (rev 279582)
@@ -1,5 +1,18 @@
 2021-07-06  Youenn Fablet  <[email protected]>
 
+        Remove MediaStreamTrack.onconstrainederror
+        https://bugs.webkit.org/show_bug.cgi?id=227696
+
+        Reviewed by Eric Carlson.
+
+        Covered by updated tests.
+
+        * Modules/mediastream/MediaStreamTrack.idl:
+        * dom/EventNames.h:
+        Remove never used/deprecated event handler.
+
+2021-07-06  Youenn Fablet  <[email protected]>
+
         Set kVTCompressionPropertyKey_MaxKeyFrameInterval in VideoSampleBufferCompressor
         https://bugs.webkit.org/show_bug.cgi?id=227680
         <rdar://78027782>

Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl (279581 => 279582)


--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl	2021-07-06 14:54:03 UTC (rev 279581)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl	2021-07-06 15:17:41 UTC (rev 279582)
@@ -52,8 +52,6 @@
     MediaTrackConstraints getConstraints();
     MediaTrackSettings getSettings();
     Promise<undefined> applyConstraints(optional MediaTrackConstraints constraints);
-
-    attribute EventHandler onoverconstrained;
 };
 
 [

Modified: trunk/Source/WebCore/dom/EventNames.h (279581 => 279582)


--- trunk/Source/WebCore/dom/EventNames.h	2021-07-06 14:54:03 UTC (rev 279581)
+++ trunk/Source/WebCore/dom/EventNames.h	2021-07-06 15:17:41 UTC (rev 279582)
@@ -193,7 +193,6 @@
     macro(online) \
     macro(open) \
     macro(orientationchange) \
-    macro(overconstrained) \
     macro(overflowchanged) \
     macro(pagehide) \
     macro(pageshow) \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to