Title: [279728] trunk/Source/WebCore
Revision
279728
Author
[email protected]
Date
2021-07-08 10:17:09 -0700 (Thu, 08 Jul 2021)

Log Message

Add logging for legacy AppHighlight decoding to aid in future debugging.
https://bugs.webkit.org/show_bug.cgi?id=227591

Reviewed by Tim Horton.

* Modules/highlight/AppHighlightRangeData.cpp:
(WebCore::AppHighlightRangeData::decode):
* platform/Logging.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (279727 => 279728)


--- trunk/Source/WebCore/ChangeLog	2021-07-08 17:13:39 UTC (rev 279727)
+++ trunk/Source/WebCore/ChangeLog	2021-07-08 17:17:09 UTC (rev 279728)
@@ -1,3 +1,14 @@
+2021-07-08  Megan Gardner  <[email protected]>
+
+        Add logging for legacy AppHighlight decoding to aid in future debugging.
+        https://bugs.webkit.org/show_bug.cgi?id=227591
+
+        Reviewed by Tim Horton.
+
+        * Modules/highlight/AppHighlightRangeData.cpp:
+        (WebCore::AppHighlightRangeData::decode):
+        * platform/Logging.h:
+
 2021-07-08  Chris Dumez  <[email protected]>
 
         [WebCrypto] deriveBits() fails if length is not a multiple of 8 for ECDH algorithm

Modified: trunk/Source/WebCore/Modules/highlight/AppHighlightRangeData.cpp (279727 => 279728)


--- trunk/Source/WebCore/Modules/highlight/AppHighlightRangeData.cpp	2021-07-08 17:13:39 UTC (rev 279727)
+++ trunk/Source/WebCore/Modules/highlight/AppHighlightRangeData.cpp	2021-07-08 17:17:09 UTC (rev 279728)
@@ -31,6 +31,7 @@
 #include "Document.h"
 #include "DocumentMarkerController.h"
 #include "HTMLBodyElement.h"
+#include "Logging.h"
 #include "Node.h"
 #include "RenderedDocumentMarker.h"
 #include "SharedBuffer.h"
@@ -120,6 +121,7 @@
         if (!decoder.rewind(sizeof(highlightFileSignature)))
             return std::nullopt;
         version = 0;
+        RELEASE_LOG(AppHighlights, "Decoded legacy (v0) highlight.");
     }
     
     std::optional<String> identifier;

Modified: trunk/Source/WebCore/platform/Logging.h (279727 => 279728)


--- trunk/Source/WebCore/platform/Logging.h	2021-07-08 17:13:39 UTC (rev 279727)
+++ trunk/Source/WebCore/platform/Logging.h	2021-07-08 17:17:09 UTC (rev 279728)
@@ -39,6 +39,7 @@
 #define WEBCORE_LOG_CHANNELS(M) \
     M(Accessibility) \
     M(Animations) \
+    M(AppHighlights) \
     M(ApplePay) \
     M(Archives) \
     M(BackForwardCache) \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to