Title: [279789] trunk/Source/WebCore
- Revision
- 279789
- Author
- [email protected]
- Date
- 2021-07-09 10:36:12 -0700 (Fri, 09 Jul 2021)
Log Message
[LFC][IFC] Negative padding values are invalid (inline box)
https://bugs.webkit.org/show_bug.cgi?id=227838
Reviewed by Antti Koivisto.
Negative values for padding properties are invalid.
https://drafts.csswg.org/css-box/#padding-physical
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (279788 => 279789)
--- trunk/Source/WebCore/ChangeLog 2021-07-09 17:32:53 UTC (rev 279788)
+++ trunk/Source/WebCore/ChangeLog 2021-07-09 17:36:12 UTC (rev 279789)
@@ -1,3 +1,16 @@
+2021-07-09 Alan Bujtas <[email protected]>
+
+ [LFC][IFC] Negative padding values are invalid (inline box)
+ https://bugs.webkit.org/show_bug.cgi?id=227838
+
+ Reviewed by Antti Koivisto.
+
+ Negative values for padding properties are invalid.
+ https://drafts.csswg.org/css-box/#padding-physical
+
+ * layout/integration/LayoutIntegrationCoverage.cpp:
+ (WebCore::LayoutIntegration::canUseForChild):
+
2021-07-09 Chris Dumez <[email protected]>
[WebCrypto] deriveBits() incorrectly throws for PBKDF2 algorithm when the password is empty
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (279788 => 279789)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2021-07-09 17:32:53 UTC (rev 279788)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2021-07-09 17:36:12 UTC (rev 279789)
@@ -270,8 +270,8 @@
case AvoidanceReason::InlineBoxHasBackground:
stream << "inline box has background";
break;
- case AvoidanceReason::InlineBoxHasMarginOrPadding:
- stream << "inline box has margin or padding";
+ case AvoidanceReason::InlineBoxHasNegativeMargin:
+ stream << "inline box has negative margin";
break;
default:
break;
@@ -706,9 +706,8 @@
SET_REASON_AND_RETURN_IF_NEEDED(InlineBoxHasBackground, reasons, includeReasons);
if (style.hasOutline())
SET_REASON_AND_RETURN_IF_NEEDED(ContentHasOutline, reasons, includeReasons);
- if (renderInline.marginLeft() < 0 || renderInline.marginRight() < 0 || renderInline.marginTop() < 0 || renderInline.marginBottom() < 0
- || renderInline.paddingLeft() < 0 || renderInline.paddingRight() < 0 || renderInline.paddingTop() < 0 || renderInline.paddingBottom() < 0)
- SET_REASON_AND_RETURN_IF_NEEDED(InlineBoxHasMarginOrPadding, reasons, includeReasons);
+ if (renderInline.marginLeft() < 0 || renderInline.marginRight() < 0 || renderInline.marginTop() < 0 || renderInline.marginBottom() < 0)
+ SET_REASON_AND_RETURN_IF_NEEDED(InlineBoxHasNegativeMargin, reasons, includeReasons);
if (renderInline.isInFlowPositioned())
SET_REASON_AND_RETURN_IF_NEEDED(ChildBoxIsFloatingOrPositioned, reasons, includeReasons);
if (renderInline.containingBlock()->style().lineBoxContain() != RenderStyle::initialLineBoxContain())
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h (279788 => 279789)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h 2021-07-09 17:32:53 UTC (rev 279788)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h 2021-07-09 17:36:12 UTC (rev 279789)
@@ -99,7 +99,7 @@
InlineBoxNeedsLayer = 1LLU << 59,
InlineBoxHasBorderOrBorderImage = 1LLU << 60,
InlineBoxHasBackground = 1LLU << 61,
- InlineBoxHasMarginOrPadding = 1LLU << 62,
+ InlineBoxHasNegativeMargin = 1LLU << 62,
EndOfReasons = 1LLU << 63
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
