Title: [279808] trunk
Revision
279808
Author
[email protected]
Date
2021-07-10 13:08:23 -0700 (Sat, 10 Jul 2021)

Log Message

Unreviewed, reverting r279803.
https://bugs.webkit.org/show_bug.cgi?id=227850

Introduce many crashes on AS-mac Debug bot

Reverted changeset:

"document.readyState should be "complete" after calling
DOMParser.parseFromString()"
https://bugs.webkit.org/show_bug.cgi?id=227846
https://commits.webkit.org/r279803

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (279807 => 279808)


--- trunk/LayoutTests/ChangeLog	2021-07-10 19:41:04 UTC (rev 279807)
+++ trunk/LayoutTests/ChangeLog	2021-07-10 20:08:23 UTC (rev 279808)
@@ -1,3 +1,17 @@
+2021-07-10  Commit Queue  <[email protected]>
+
+        Unreviewed, reverting r279803.
+        https://bugs.webkit.org/show_bug.cgi?id=227850
+
+        Introduce many crashes on AS-mac Debug bot
+
+        Reverted changeset:
+
+        "document.readyState should be "complete" after calling
+        DOMParser.parseFromString()"
+        https://bugs.webkit.org/show_bug.cgi?id=227846
+        https://commits.webkit.org/r279803
+
 2021-07-09  Tim Nguyen  <[email protected]>
 
         Import blink reference tests for <dialog> element

Deleted: trunk/LayoutTests/fast/dom/Document/createdDocument-readyState-expected.txt (279807 => 279808)


--- trunk/LayoutTests/fast/dom/Document/createdDocument-readyState-expected.txt	2021-07-10 19:41:04 UTC (rev 279807)
+++ trunk/LayoutTests/fast/dom/Document/createdDocument-readyState-expected.txt	2021-07-10 20:08:23 UTC (rev 279808)
@@ -1,19 +0,0 @@
-Tests document.readyState() for documents created by _javascript_
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-htmlDocument = document.implementation.createHTMLDocument()
-PASS htmlDocument.readyState is "loading"
-htmlDocument.close()
-PASS htmlDocument.readyState is "complete"
-xhtmlDocument = document.implementation.createDocument('http://www.w3.org/1999/xhtml', 'html', null)
-PASS xhtmlDocument.readyState is "complete"
-svgDocument = document.implementation.createDocument('http://www.w3.org/2000/svg', 'svg', null)
-PASS svgDocument.readyState is "complete"
-xmlDocument = (new DOMParser()).parseFromString('', 'text/xml')
-PASS xmlDocument.readyState is "complete"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-

Deleted: trunk/LayoutTests/fast/dom/Document/createdDocument-readyState.html (279807 => 279808)


--- trunk/LayoutTests/fast/dom/Document/createdDocument-readyState.html	2021-07-10 19:41:04 UTC (rev 279807)
+++ trunk/LayoutTests/fast/dom/Document/createdDocument-readyState.html	2021-07-10 20:08:23 UTC (rev 279808)
@@ -1,22 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<script src=""
-<script>
-description("Tests document.readyState() for documents created by _javascript_");
-
-evalAndLog("htmlDocument = document.implementation.createHTMLDocument()");
-shouldBeEqualToString("htmlDocument.readyState", "loading"); // WebKit and Blink say "loading", Gecko says "complete".
-evalAndLog("htmlDocument.close()");
-shouldBeEqualToString("htmlDocument.readyState", "complete");
-
-evalAndLog("xhtmlDocument = document.implementation.createDocument('http://www.w3.org/1999/xhtml', 'html', null)");
-shouldBeEqualToString("xhtmlDocument.readyState", "complete");
-
-evalAndLog("svgDocument = document.implementation.createDocument('http://www.w3.org/2000/svg', 'svg', null)");
-shouldBeEqualToString("svgDocument.readyState", "complete");
-
-evalAndLog("xmlDocument = (new DOMParser()).parseFromString('<html></html>', 'text/xml')");
-shouldBeEqualToString("xmlDocument.readyState", "complete");
-</script>
-</html>

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279807 => 279808)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-10 19:41:04 UTC (rev 279807)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-10 20:08:23 UTC (rev 279808)
@@ -1,3 +1,17 @@
+2021-07-10  Commit Queue  <[email protected]>
+
+        Unreviewed, reverting r279803.
+        https://bugs.webkit.org/show_bug.cgi?id=227850
+
+        Introduce many crashes on AS-mac Debug bot
+
+        Reverted changeset:
+
+        "document.readyState should be "complete" after calling
+        DOMParser.parseFromString()"
+        https://bugs.webkit.org/show_bug.cgi?id=227846
+        https://commits.webkit.org/r279803
+
 2021-07-09  Chris Dumez  <[email protected]>
 
         document.readyState should be "complete" after calling DOMParser.parseFromString()

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/domparsing/xmldomparser-expected.txt (279807 => 279808)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/domparsing/xmldomparser-expected.txt	2021-07-10 19:41:04 UTC (rev 279807)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/domparsing/xmldomparser-expected.txt	2021-07-10 20:08:23 UTC (rev 279808)
@@ -1,3 +1,3 @@
 
-PASS XML Dom Parse readyState Test
+FAIL XML Dom Parse readyState Test assert_equals: expected "complete" but got "interactive"
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/responsexml-document-properties-expected.txt (279807 => 279808)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/responsexml-document-properties-expected.txt	2021-07-10 19:41:04 UTC (rev 279807)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/responsexml-document-properties-expected.txt	2021-07-10 20:08:23 UTC (rev 279808)
@@ -6,7 +6,7 @@
 PASS referrer
 PASS title
 PASS contentType
-PASS readyState
+FAIL readyState assert_equals: expected "complete" but got "interactive"
 PASS location
 PASS defaultView
 PASS body

Modified: trunk/Source/WebCore/ChangeLog (279807 => 279808)


--- trunk/Source/WebCore/ChangeLog	2021-07-10 19:41:04 UTC (rev 279807)
+++ trunk/Source/WebCore/ChangeLog	2021-07-10 20:08:23 UTC (rev 279808)
@@ -1,3 +1,17 @@
+2021-07-10  Commit Queue  <[email protected]>
+
+        Unreviewed, reverting r279803.
+        https://bugs.webkit.org/show_bug.cgi?id=227850
+
+        Introduce many crashes on AS-mac Debug bot
+
+        Reverted changeset:
+
+        "document.readyState should be "complete" after calling
+        DOMParser.parseFromString()"
+        https://bugs.webkit.org/show_bug.cgi?id=227846
+        https://commits.webkit.org/r279803
+
 2021-07-09  Chris Dumez  <[email protected]>
 
         document.readyState should be "complete" after calling DOMParser.parseFromString()

Modified: trunk/Source/WebCore/dom/Document.cpp (279807 => 279808)


--- trunk/Source/WebCore/dom/Document.cpp	2021-07-10 19:41:04 UTC (rev 279807)
+++ trunk/Source/WebCore/dom/Document.cpp	2021-07-10 20:08:23 UTC (rev 279808)
@@ -3103,7 +3103,6 @@
         // Because we have no frame, we don't know if all loading has completed,
         // so we just call implicitClose() immediately. FIXME: This might fire
         // the load event prematurely <http://bugs.webkit.org/show_bug.cgi?id=14568>.
-        setReadyState(Complete);
         implicitClose();
         return;
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to