[webkit-changes] [279974] trunk/Source

Thu, 15 Jul 2021 19:09:49 -0700

Title: [279974] trunk/Source
Revision
279974
Author
[email protected]
Date
2021-07-15 19:09:39 -0700 (Thu, 15 Jul 2021)

Log Message

[Wk1] media/media-source/media-webm-opus-partial.html is a consistent failure (Enable VP8/VP9/Vorbis/Opus in WebKitLegacy)
https://bugs.webkit.org/show_bug.cgi?id=228005
rdar://80346720

Reviewed by Jer Noble.

Source/WebCore:

There are already tests running under Wk1 that will exercise this code (and will no longer fail)

* page/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::setVorbisDecoderEnabled):
Carry settings to PlatformMediaSessionManager
(WebCore::RuntimeEnabledFeatures::setOpusDecoderEnabled):
Carry settings to PlatformMediaSessionManager
* page/RuntimeEnabledFeatures.h:

Source/WebKit:

* Shared/WebPreferencesDefaultValues.cpp:
* Shared/WebPreferencesDefaultValues.h: Don't make webm parser conditional on VP9
being enabled; it's used with other codecs too and is codec-agnostic to start with.

Source/WebKitLegacy/mac:

* WebView/WebPreferencesDefaultValues.h: Add relevant settings getter methods.
* WebView/WebPreferencesDefaultValues.mm:
(WebKit::defaultWebMParserEnabled):
(WebKit::defaultVP8DecoderEnabled):
(WebKit::defaultVP9DecoderEnabled):

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml: Enable VP8/VP9/Vorbis/Opus
codecs for WebKitLegacy, no reasons they weren't already enabled.

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (279973 => 279974)


--- trunk/Source/WTF/ChangeLog	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WTF/ChangeLog	2021-07-16 02:09:39 UTC (rev 279974)
@@ -1,3 +1,14 @@
+2021-07-15  Jean-Yves Avenard  <[email protected]>
+
+        [Wk1] media/media-source/media-webm-opus-partial.html is a consistent failure (Enable VP8/VP9/Vorbis/Opus in WebKitLegacy)
+        https://bugs.webkit.org/show_bug.cgi?id=228005
+        rdar://80346720
+
+        Reviewed by Jer Noble.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml: Enable VP8/VP9/Vorbis/Opus
+        codecs for WebKitLegacy, no reasons they weren't already enabled.
+
 2021-07-15  Joonghun Park  <[email protected]>
 
         Unreviewed. Fix the build warning below since r279895.

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (279973 => 279974)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-07-16 02:09:39 UTC (rev 279974)
@@ -1082,10 +1082,11 @@
   webcoreBinding: none
   condition: ENABLE(VP9)
   defaultValue:
+    WebKitLegacy:
+      default: WebKit::defaultVP8DecoderEnabled()
     WebKit:
       default: WebKit::defaultVP8DecoderEnabled()
 
-# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
 VP9DecoderEnabled:
   type: bool
   humanReadableName: "VP9 decoder"
@@ -1095,7 +1096,7 @@
     WebCore:
       default: false
     WebKitLegacy:
-      default: false
+      default: WebKit::defaultVP9DecoderEnabled()
     WebKit:
       default: WebKit::defaultVP9DecoderEnabled()
 
@@ -1253,10 +1254,10 @@
   webcoreBinding: RuntimeEnabledFeatures
   humanReadableName: "WebM MSE parser"
   humanReadableDescription: "Enable WebM MSE parser"
-  condition: ENABLE(MEDIA_SOURCE) && ENABLE(VP9)
+  condition: ENABLE(MEDIA_SOURCE)
   defaultValue:
     WebKitLegacy:
-      default: false
+      default: WebKit::defaultWebMParserEnabled()
     WebKit:
       default: WebKit::defaultWebMParserEnabled()

Modified: trunk/Source/WebCore/ChangeLog (279973 => 279974)


--- trunk/Source/WebCore/ChangeLog	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WebCore/ChangeLog	2021-07-16 02:09:39 UTC (rev 279974)
@@ -1,5 +1,22 @@
 2021-07-15  Jean-Yves Avenard  <[email protected]>
 
+        [Wk1] media/media-source/media-webm-opus-partial.html is a consistent failure (Enable VP8/VP9/Vorbis/Opus in WebKitLegacy)
+        https://bugs.webkit.org/show_bug.cgi?id=228005
+        rdar://80346720
+
+        Reviewed by Jer Noble.
+
+        There are already tests running under Wk1 that will exercise this code (and will no longer fail)
+
+        * page/RuntimeEnabledFeatures.cpp:
+        (WebCore::RuntimeEnabledFeatures::setVorbisDecoderEnabled):
+        Carry settings to PlatformMediaSessionManager
+        (WebCore::RuntimeEnabledFeatures::setOpusDecoderEnabled):
+        Carry settings to PlatformMediaSessionManager
+        * page/RuntimeEnabledFeatures.h:
+
+2021-07-15  Jean-Yves Avenard  <[email protected]>
+
         [MSE] sequence mode is broken if GPU Process is enabled
         https://bugs.webkit.org/show_bug.cgi?id=227864
         <rdar://problem/80445041>

Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp (279973 => 279974)


--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp	2021-07-16 02:09:39 UTC (rev 279974)
@@ -33,6 +33,7 @@
 #include "RuntimeEnabledFeatures.h"
 
 #include "MediaPlayer.h"
+#include "PlatformMediaSessionManager.h"
 #include "PlatformScreen.h"
 #include <_javascript_Core/Options.h>
 #include <wtf/NeverDestroyed.h>
@@ -60,4 +61,20 @@
 }
 #endif
 
+#if ENABLE(VORBIS)
+void RuntimeEnabledFeatures::setVorbisDecoderEnabled(bool isEnabled)
+{
+    m_vorbisDecoderEnabled = isEnabled;
+    PlatformMediaSessionManager::setVorbisDecoderEnabled(isEnabled);
+}
+#endif
+
+#if ENABLE(OPUS)
+void RuntimeEnabledFeatures::setOpusDecoderEnabled(bool isEnabled)
+{
+    m_opusDecoderEnabled = isEnabled;
+    PlatformMediaSessionManager::setOpusDecoderEnabled(isEnabled);
+}
+#endif
+
 } // namespace WebCore

Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (279973 => 279974)


--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2021-07-16 02:09:39 UTC (rev 279974)
@@ -243,12 +243,12 @@
 #endif
 
 #if ENABLE(VORBIS)
-    void setVorbisDecoderEnabled(bool isEnabled) { m_vorbisDecoderEnabled = isEnabled; }
+    WEBCORE_EXPORT void setVorbisDecoderEnabled(bool isEnabled);
     bool vorbisDecoderEnabled() const { return m_vorbisDecoderEnabled; }
 #endif
 
 #if ENABLE(OPUS)
-    void setOpusDecoderEnabled(bool isEnabled) { m_opusDecoderEnabled = isEnabled; }
+    WEBCORE_EXPORT void setOpusDecoderEnabled(bool isEnabled);
     bool opusDecoderEnabled() const { return m_opusDecoderEnabled; }
 #endif

Modified: trunk/Source/WebKit/ChangeLog (279973 => 279974)


--- trunk/Source/WebKit/ChangeLog	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WebKit/ChangeLog	2021-07-16 02:09:39 UTC (rev 279974)
@@ -1,5 +1,17 @@
 2021-07-15  Jean-Yves Avenard  <[email protected]>
 
+        [Wk1] media/media-source/media-webm-opus-partial.html is a consistent failure (Enable VP8/VP9/Vorbis/Opus in WebKitLegacy)
+        https://bugs.webkit.org/show_bug.cgi?id=228005
+        rdar://80346720
+
+        Reviewed by Jer Noble.
+
+        * Shared/WebPreferencesDefaultValues.cpp:
+        * Shared/WebPreferencesDefaultValues.h: Don't make webm parser conditional on VP9
+        being enabled; it's used with other codecs too and is codec-agnostic to start with.
+
+2021-07-15  Jean-Yves Avenard  <[email protected]>
+
         [MSE] sequence mode is broken if GPU Process is enabled
         https://bugs.webkit.org/show_bug.cgi?id=227864
         <rdar://problem/80445041>

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (279973 => 279974)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-07-16 02:09:39 UTC (rev 279974)
@@ -315,6 +315,7 @@
 
     return false;
 }
+#endif // ENABLE(VP9)
 
 #if ENABLE(MEDIA_SOURCE)
 
@@ -328,6 +329,5 @@
 }
 
 #endif // ENABLE(MEDIA_SOURCE)
-#endif // ENABLE(VP9)
 
 } // namespace WebKit

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (279973 => 279974)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2021-07-16 02:09:39 UTC (rev 279974)
@@ -107,9 +107,10 @@
 bool defaultVP8DecoderEnabled();
 bool defaultVP9DecoderEnabled();
 bool defaultVP9SWDecoderEnabledOnBattery();
+#endif
+
 #if ENABLE(MEDIA_SOURCE)
 bool defaultWebMParserEnabled();
 #endif
-#endif
 
 } // namespace WebKit

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (279973 => 279974)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2021-07-16 02:09:39 UTC (rev 279974)
@@ -1,3 +1,17 @@
+2021-07-15  Jean-Yves Avenard  <[email protected]>
+
+        [Wk1] media/media-source/media-webm-opus-partial.html is a consistent failure (Enable VP8/VP9/Vorbis/Opus in WebKitLegacy)
+        https://bugs.webkit.org/show_bug.cgi?id=228005
+        rdar://80346720
+
+        Reviewed by Jer Noble.
+
+        * WebView/WebPreferencesDefaultValues.h: Add relevant settings getter methods.
+        * WebView/WebPreferencesDefaultValues.mm:
+        (WebKit::defaultWebMParserEnabled):
+        (WebKit::defaultVP8DecoderEnabled):
+        (WebKit::defaultVP9DecoderEnabled):
+
 2021-07-15  Chris Dumez  <[email protected]>
 
         Add initial support for BroadcastChannel behind a runtime flag

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h (279973 => 279974)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h	2021-07-16 02:09:39 UTC (rev 279974)
@@ -85,4 +85,13 @@
 bool defaultWheelEventGesturesBecomeNonBlocking();
 #endif
 
+#if ENABLE(MEDIA_SOURCE)
+bool defaultWebMParserEnabled();
+#endif
+
+#if ENABLE(VP9)
+bool defaultVP8DecoderEnabled();
+bool defaultVP9DecoderEnabled();
+#endif
+
 } // namespace WebKit

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm (279973 => 279974)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm	2021-07-16 02:07:47 UTC (rev 279973)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm	2021-07-16 02:09:39 UTC (rev 279974)
@@ -287,4 +287,39 @@
 
 #endif
 
+#if ENABLE(MEDIA_SOURCE)
+
+bool defaultWebMParserEnabled()
+{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
+    return isFeatureFlagEnabled("webm_parser");
+#endif
+
+    return true;
+}
+
+#endif // ENABLE(MEDIA_SOURCE)
+
+#if ENABLE(VP9)
+
+bool defaultVP8DecoderEnabled()
+{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
+    return isFeatureFlagEnabled("vp8_decoder");
+#endif
+
+    return false;
+}
+
+bool defaultVP9DecoderEnabled()
+{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
+    return isFeatureFlagEnabled("vp9_decoder");
+#endif
+
+    return true;
+}
+
+#endif // ENABLE(VP9)
+
 } // namespace WebKit

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to