Title: [280045] trunk/Source/WebInspectorUI
Revision
280045
Author
[email protected]
Date
2021-07-19 13:49:56 -0700 (Mon, 19 Jul 2021)

Log Message

Web Inspector: REGRESSION(?): alpha slider doesn't match alpha input for `transparent` in color picker
https://bugs.webkit.org/show_bug.cgi?id=227941
<rdar://problem/80557438>

Reviewed by Devin Rousso.

* UserInterface/Views/Slider.js:
(WI.Slider.prototype.set value):
When the initial value was set to 0, `set value` was exiting early when the passed value was 0.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (280044 => 280045)


--- trunk/Source/WebInspectorUI/ChangeLog	2021-07-19 20:45:37 UTC (rev 280044)
+++ trunk/Source/WebInspectorUI/ChangeLog	2021-07-19 20:49:56 UTC (rev 280045)
@@ -1,3 +1,15 @@
+2021-07-19  Nikita Vasilyev  <[email protected]>
+
+        Web Inspector: REGRESSION(?): alpha slider doesn't match alpha input for `transparent` in color picker
+        https://bugs.webkit.org/show_bug.cgi?id=227941
+        <rdar://problem/80557438>
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/Slider.js:
+        (WI.Slider.prototype.set value):
+        When the initial value was set to 0, `set value` was exiting early when the passed value was 0.
+
 2021-07-19  Patrick Angle  <[email protected]>
 
         Web Inspector: Elements: selecting a sibling node in the breadcrumb navigation doesn't do anything

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Slider.js (280044 => 280045)


--- trunk/Source/WebInspectorUI/UserInterface/Views/Slider.js	2021-07-19 20:45:37 UTC (rev 280044)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Slider.js	2021-07-19 20:49:56 UTC (rev 280045)
@@ -59,8 +59,10 @@
     {
         value = Math.max(Math.min(value, 1), 0);
 
-        if (value === this._value)
+        if (value === this._value) {
+            this.recalculateKnobY();
             return;
+        }
 
         this.knobY = value;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to