Title: [280141] trunk/LayoutTests
- Revision
- 280141
- Author
- [email protected]
- Date
- 2021-07-21 09:16:17 -0700 (Wed, 21 Jul 2021)
Log Message
[AspectRatio] Fix select-element-001.html
https://bugs.webkit.org/show_bug.cgi?id=228144
Patch by Rob Buis <[email protected]> on 2021-07-21
Reviewed by Manuel Rego Casasnovas.
LayoutTests/imported/w3c:
Import fixed select-element-001.html based on SHA c2ddbb6.
* web-platform-tests/css/css-sizing/aspect-ratio/select-element-001-expected.html:
* web-platform-tests/css/css-sizing/aspect-ratio/select-element-001.html:
* web-platform-tests/css/css-sizing/aspect-ratio/w3c-import.log:
LayoutTests:
Now select-element-001.html passes.
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (280140 => 280141)
--- trunk/LayoutTests/ChangeLog 2021-07-21 15:32:30 UTC (rev 280140)
+++ trunk/LayoutTests/ChangeLog 2021-07-21 16:16:17 UTC (rev 280141)
@@ -1,3 +1,14 @@
+2021-07-21 Rob Buis <[email protected]>
+
+ [AspectRatio] Fix select-element-001.html
+ https://bugs.webkit.org/show_bug.cgi?id=228144
+
+ Reviewed by Manuel Rego Casasnovas.
+
+ Now select-element-001.html passes.
+
+ * TestExpectations:
+
2021-07-20 Ayumi Kojima <[email protected]>
[iOS] http/tests/appcache/fail-on-update.html is a flaky timeout
Modified: trunk/LayoutTests/TestExpectations (280140 => 280141)
--- trunk/LayoutTests/TestExpectations 2021-07-21 15:32:30 UTC (rev 280140)
+++ trunk/LayoutTests/TestExpectations 2021-07-21 16:16:17 UTC (rev 280141)
@@ -4738,7 +4738,6 @@
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-025.html [ ImageOnlyFailure ]
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-026.html [ ImageOnlyFailure ]
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-034.html [ ImageOnlyFailure ]
-webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/select-element-001.html [ ImageOnlyFailure ]
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-001.html [ ImageOnlyFailure ]
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-002.html [ ImageOnlyFailure ]
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-003.html [ ImageOnlyFailure ]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (280140 => 280141)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-07-21 15:32:30 UTC (rev 280140)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-07-21 16:16:17 UTC (rev 280141)
@@ -1,3 +1,16 @@
+2021-07-21 Rob Buis <[email protected]>
+
+ [AspectRatio] Fix select-element-001.html
+ https://bugs.webkit.org/show_bug.cgi?id=228144
+
+ Reviewed by Manuel Rego Casasnovas.
+
+ Import fixed select-element-001.html based on SHA c2ddbb6.
+
+ * web-platform-tests/css/css-sizing/aspect-ratio/select-element-001-expected.html:
+ * web-platform-tests/css/css-sizing/aspect-ratio/select-element-001.html:
+ * web-platform-tests/css/css-sizing/aspect-ratio/w3c-import.log:
+
2021-07-20 Chris Lord <[email protected]>
Canvas and OffscreenCanvas getContext should check if argument is an object before trying to convert it to a dictionary
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/select-element-001-expected.html (280140 => 280141)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/select-element-001-expected.html 2021-07-21 15:32:30 UTC (rev 280140)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/select-element-001-expected.html 2021-07-21 16:16:17 UTC (rev 280141)
@@ -1,5 +1,11 @@
<!DOCTYPE html>
<title>CSS aspect-ratio reference: select elements</title>
+<!-- WebKit uses quirky em in user agent sheet for margins of select, avoid it -->
+<style>
+ select {
+ margin: 0px;
+ }
+</style>
<select style="height: 50px; width: 50px; background: green;">
<option value=""></option>
</select>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/select-element-001.html (280140 => 280141)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/select-element-001.html 2021-07-21 15:32:30 UTC (rev 280140)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/select-element-001.html 2021-07-21 16:16:17 UTC (rev 280141)
@@ -3,6 +3,12 @@
<link rel="author" title="Mozilla" href=""
<link rel="help" href=""
<link rel="match" href=""
+<!-- WebKit uses quirky em in user agent sheet for margins of select, avoid it -->
+<style>
+ select {
+ margin: 0px;
+ }
+</style>
<!-- Sanity Check - aspect-ratio should be applied on the select element -->
<select style="height: 50px; aspect-ratio: 1/1; background: green;">
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/w3c-import.log (280140 => 280141)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/w3c-import.log 2021-07-21 15:32:30 UTC (rev 280140)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/w3c-import.log 2021-07-21 16:16:17 UTC (rev 280141)
@@ -205,8 +205,6 @@
/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-011.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-012-expected.xht
/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-012.html
-/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-013-expected.xht
-/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-013.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-014-expected.xht
/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-014.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-015-expected.xht
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
